Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net][net.socket.select][imx-rt series] test fails (k_uptime_get_32() - tstamp <= FUZZ is false) #25991

Closed
hakehuang opened this issue Jun 5, 2020 · 4 comments · Fixed by #26001
Assignees
Labels
area: Ethernet area: Sockets Networking sockets area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP
Milestone

Comments

@hakehuang
Copy link
Collaborator

hakehuang commented Jun 5, 2020

Describe the bug
Assertion failed at WEST_TOPDIR/zephyr/tests/net/socket/select/src/main.c:160: test_select: (k_uptime_get_32() - tstamp <= FUZZ is false)

all rt baords with net support fail:
mimxrt1020_evk
mimxrt1060_evk
mimxrt1064_evk
mimxrt1050_evk

for v2.3.0-rc1 this case is OK.

To Reproduce
Steps to reproduce the behavior:

  1. mkdir build; cd build
  2. cmake -DBOARD=mimxrt1060_evk ..
  3. make flash

Expected behavior
all test pass.

Impact
net socket function

Screenshots or console output
'''

*** Booting Zephyr OS version 2.3.0-rc2 ***

I: ETH_0 enabled 100M full-duplex mode.
Running test suite socket_select

starting test - test_fd_set
PASS - test_fd_set

starting test - test_select
E: 0x00000000 is not a valid NET_SOCKET
E: address is not a known kernel object
E: 0x00000000 is not a valid NET_SOCKET
E: address is not a known kernel object

Assertion failed at WEST_TOPDIR/zephyr/tests/net/socket/select/src/main.c:160: test_select: (k_uptime_get_32() - tstamp <= FUZZ is false)

FAIL - test_select

Test suite socket_select failed.

PROJECT EXECUTION FAILED

'''

Environment (please complete the following information):

  • OS: (e.g. Linux)
  • Toolchain (Zephyr SDK, ...)
  • v.2.3.0-rc2
@hakehuang hakehuang added bug The issue is a bug, or the PR is fixing a bug area: Ethernet area: Sockets Networking sockets area: Tests Issues related to a particular existing or missing test platform: NXP NXP labels Jun 5, 2020
@hakehuang
Copy link
Collaborator Author

@dleach02 , @MaureenHelm

@hakehuang hakehuang added this to the v2.3.0 milestone Jun 5, 2020
@carlescufi
Copy link
Member

Probably duplicate of #25990

@dleach02
Copy link
Member

dleach02 commented Jun 5, 2020

yep... looks like we introduced a bug in the last week... given that it is across multiple (all?) architectures maybe we should fix this before doing final?

rlubos added a commit to rlubos/zephyr that referenced this issue Jun 5, 2020
When `z_get_fd_obj_and_vtable()` function returns NULL (no valid entry
in the FD table for the socket), there is no need for further usermode
checks on the `ctx` pointer, as there is nothing to invalidate in that
case.

Fixes zephyrproject-rtos#25990
Fixes zephyrproject-rtos#25991

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
carlescufi pushed a commit that referenced this issue Jun 5, 2020
When `z_get_fd_obj_and_vtable()` function returns NULL (no valid entry
in the FD table for the socket), there is no need for further usermode
checks on the `ctx` pointer, as there is nothing to invalidate in that
case.

Fixes #25990
Fixes #25991

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
@dleach02
Copy link
Member

dleach02 commented Jun 5, 2020

I can confirm that #26001 fixes this problem. I reproduced the problem before and then confirmed that the test passed after applying the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Ethernet area: Sockets Networking sockets area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants