Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function l2cap_br_conn_req in /subsys/bluetooth/host/l2cap_br.c references uninitialized pointer #2882

Closed
zephyrbot opened this issue Dec 2, 2016 · 6 comments
Closed

function l2cap_br_conn_req in /subsys/bluetooth/host/l2cap_br.c references uninitialized pointer #2882

zephyrbot opened this issue Dec 2, 2016 · 6 comments
Assignees
@sjanc
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone
v1.7.0

Comments

@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 2, 2016 •
edited
Loading

Reported by David Kinder:

uninitialized pointer read in function l2cap_br_conn_req in /subsys/bluetooth/host/l2cap_br.c

BR/EDR (aka Bluetooth Classic) is still a work in progress and we don't have any real target hardware for it yet (besides qemu).

(Imported from Jira ZEP-1405)
@zephyrbot
Copy link
Collaborator Author

by Johan Hedberg:

This seems to be a regression from the following patch:

commit 941104a
Author: Arkadiusz Lichwa arkadiusz.lichwa@tieto.com
Date: Thu Oct 6 14:02:17 2016 +0200

Bluetooth: L2CAP: Refactor BR/EDR connection request handler

@zephyrbot
Copy link
Collaborator Author

by Johan Hedberg:

Also, unlike the description, this has nothing to do with the IP stack.

Arek, in case you don't have access to the coverity report, the issue is that there are several goto's to the 'done' label where 'chan' is uninitialized.

@zephyrbot
Copy link
Collaborator Author

by Arkadiusz Lichwa:

allright, will check that

@zephyrbot
Copy link
Collaborator Author

by Mark Linkmeyer:

Correcting the priority field

@zephyrbot
Copy link
Collaborator Author

by Andrei Laperie:

low pri as that's BR-EDR -related

@zephyrbot
Copy link
Collaborator Author

by Johan Hedberg:

This was already fixed by:

commit ba2adb7
Author: Szymon Janc szymon.janc@codecoup.pl
Date: Thu Dec 22 19:48:08 2016 +0100

Bluetooth: L2CAP: Fix use of uninitializer pointer

That commit had a reference to this Jira item, so not sure why it didn't show up here.

@zephyrbot zephyrbot added priority: low Low impact/importance bug area: Bluetooth bug The issue is a bug, or the PR is fixing a bug labels Sep 23, 2017
@zephyrbot zephyrbot added this to the v1.7.0 milestone Sep 23, 2017
fkan-ec pushed a commit to fkan-ec/zephyr that referenced this issue Jan 17, 2022
@SaurabhK-88
[BUG zephyrproject-rtos#2882] arch: arm64: core: Add IPI for system halt
c9f99db 
- Add a new IPI interrupt to signal other CPU's to jump to a routine
  which spins endlessly whenever there is a fatal error on a CPU

Signed-off-by: Saurabh Karajgaonkar <saurabh.karajgaonkar@edgeq.io>
fkan-ec pushed a commit to fkan-ec/zephyr that referenced this issue Jan 17, 2022
@onkark911
Merge pull request zephyrproject-rtos#15 from ec-platform-sw/BUG_2882
21ca5e6 
[BUG zephyrproject-rtos#2882] arch: arm64: core: Add IPI for system halt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjanc sjanc

Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@sjanc @zephyrbot