Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Documentation issue in 'guides/kconfig/tips' - broken hyperlink from kconfiglib to zephyrproject #66701

Closed
ngenetzky-appareo opened this issue Dec 20, 2023 · 4 comments · Fixed by #66719

Comments

@ngenetzky-appareo
Copy link

ngenetzky-appareo commented Dec 20, 2023

Describe the bug

Broke hyperlink from https://pypi.org/project/kconfiglib/ to zephyrproject.

Here is the text with the hyperlink:

See this page for some Kconfig tips and best practices.

Environment

CC: @ulfalizer

Cross-Posted:

Copy link

Hi @ngenetzky-appareo! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

@kartben
Copy link
Collaborator

kartben commented Dec 20, 2023

Hi @ngenetzky-appareo -- thanks for the report! It's not clear to me if there is anything to track on the Zephyr side of things? The "Kconfig - Tips and Best Practices" page doesn't have any broken links, correct? It looks as it's rather some broken links in the upstream Kconfiglib docs and published pypi package?

@ngenetzky-appareo
Copy link
Author

ngenetzky-appareo commented Dec 20, 2023 via email

@kartben
Copy link
Collaborator

kartben commented Dec 20, 2023

Oh, I see! It used to be at a different URL, gotcha. Yes, we have a way to have redirects. Will make a PR :)

kartben added a commit to kartben/zephyr that referenced this issue Dec 20, 2023
Documentation pages around Kconfig have moved around on a couple of
occasions in the past [1] [2] and current redirects were dysfonctional
(leading /) and incomplete, while an entire set of redirects was also
missing. This notably fixes the "browse latest development version of
this page" link on
https://docs.zephyrproject.org/2.7.5/guides/build/kconfig/tips.html or a
link to the "Kconfig tips" page as found in Kconfiglib's current README
(https://pypi.org/project/kconfiglib/)

[1] commit 5342bc6 [2] commit
5c88418

Fixes zephyrproject-rtos#66701

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben self-assigned this Dec 20, 2023
fabiobaltieri pushed a commit that referenced this issue Dec 21, 2023
Documentation pages around Kconfig have moved around on a couple of
occasions in the past [1] [2] and current redirects were dysfonctional
(leading /) and incomplete, while an entire set of redirects was also
missing. This notably fixes the "browse latest development version of
this page" link on
https://docs.zephyrproject.org/2.7.5/guides/build/kconfig/tips.html or a
link to the "Kconfig tips" page as found in Kconfiglib's current README
(https://pypi.org/project/kconfiglib/)

[1] commit 5342bc6 [2] commit
5c88418

Fixes #66701

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants