drivers: counter: sam: The alarm 1 do not generate interrupt

[nandojve]

Describe the bug
The counter driver for Atmel SAM works fine on Alarm 0. When switch to Alarm 1 the interrupt is never generated.

To Reproduce
Build the samples/drivers/counter/alarm and check that counter is working.
Change the line from 0 to 1.

zephyr/samples/drivers/counter/alarm/src/main.c

Line 14 in 94cd786

#define ALARM_CHANNEL_ID 0

Build the application again and test. The interrupt never happen.

Expected behavior
The counter should work on RB (Alarm 1) the same way that work on RA (Alarm 0).

Impact
Alarm 1 do not work.

Environment (please complete the following information):

• OS: Linux
• Toolchain Zephyr SDK 0.17.0
• Commit mainline

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[MCHP-MPU-Solutions-SHA]

Hi, I think this issue can be fixed by this patch:

$ git diff  drivers/counter/counter_sam_tc.c 
diff --git a/drivers/counter/counter_sam_tc.c b/drivers/counter/counter_sam_tc.c
index 57ae3c6dd67..eb248a301b3 100644
--- a/drivers/counter/counter_sam_tc.c
+++ b/drivers/counter/counter_sam_tc.c
@@ -356,6 +356,7 @@ static DEVICE_API(counter, counter_sam_driver_api) = {
 
 #define COUNTER_SAM_TC_CMR(n)  \
                 (TC_CMR_TCCLKS(DT_INST_PROP_OR(n, clk, 0)) \
+               | TC_CMR_WAVEFORM_EEVT_XC0 \
                | TC_CMR_WAVEFORM_WAVSEL_UP_RC \
                | TC_CMR_WAVE)

For the details of EEVT field, please refer to TC_CMR register in this datasheet:
https://ww1.microchip.com/downloads/en/DeviceDoc/Atmel-44003-32-bit-Cortex-M7-Microcontroller-SAM-V71Q-SAM-V71N-SAM-V71J_Datasheet.pdf

Sorry, I'm in MPU team and can not find a SAM MCU board for verification.
Who has a SAM MCU board and will help to verify this patch?

Many thanks.
Xing.

[nandojve]

Hi @MCHP-MPU-Solutions-SHA,

Thank you for the input.

Would you mind to open a PR in Zephyr with this fix ? I can test locally and approve then.

Don't forget to follow the procedures about adding-links to automatically link the PR with this Issue.

[MCHP-MPU-Solutions-SHA]

Hi @nandojve,

I have create a PR for fixing this issue: PR#93755, and add link to this issue.
Please help to check it.