tests/kernel/sched/schedule_api: Restore spinning for timer alignment #13916
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13916 +/- ##
=========================================
Coverage ? 52.31%
=========================================
Files ? 307
Lines ? 45436
Branches ? 10512
=========================================
Hits ? 23771
Misses ? 16874
Partials ? 4791Continue to review full report at Codecov.
|
Commit 0cc362f ("tests/kernel: Simplify timer spinning") was added to work around a qemu bug with dropped interrupts on x86_64. But it turns out that the tick alignment that the original implementation provided (fundamentally, it spins waiting on the timer driver to report tick changes) was needed for correct operation on nRF52. The effectively revert that commit (and refactors all the spinning into a single utility) and replaces it with a workaround targeted to qemu on x86_64 only. Fixes zephyrproject-rtos#11721 Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
|
Rebased and pushed. Finally noticed why test code sometimes fails to retry spurious failures and filed it in #13956 |
|
Yeah, this isn't likely to show a green. The problem is spurious failure on non-default platforms (which are run when you modify a test) are not retried in CI. I hereby request Dispensation. |
granted! |
Commit 0cc362f ("tests/kernel: Simplify timer spinning") was
added to work around a qemu bug with dropped interrupts on x86_64.
But it turns out that the tick alignment that the original
implementation provided (fundamentally, it spins waiting on the timer
driver to report tick changes) was needed for correct operation on
nRF52.
The effectively revert that commit (and refactors all the spinning
into a single utility) and replaces it with a workaround targeted to
qemu on x86_64 only. Fixes #11721
Signed-off-by: Andy Ross andrew.j.ross@intel.com