scripts: requirements.txt: freeze pyyaml at 3.13 #14494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbolivar
requested review from
ulfalizer,
nashif,
MaureenHelm,
carlescufi and
galak
PyYAML 5.1 was just released, which doesn't support !include as previous versions do. This breaks our DTS bindings parsing. Freeze the PyYAML version in requirements.txt to a known good version to prevent new installs from breaking. Reported-by: Andy Doan <andy@foundries.io> Reported-by: Michael Scott <mike@foundries.io> Signed-off-by: Marti Bolivar <marti@foundries.io>
|
@nashif I didn't. I meant this as a quick fix until our YAML was updated to work with 5.1. I guess I can drop this as we have to upgrade now? |
|
@mbolivar I did not verify the conflict, but it seems we need to move to another version to resolve this conflict like indicated in the bug. Do not know if 3.13 will do. |
|
@ulfalizer @galak i've just filed a bug instead: #14496 |
Codecov Report
@@ Coverage Diff @@
## master #14494 +/- ##
=========================================
Coverage ? 51.99%
=========================================
Files ? 308
Lines ? 45572
Branches ? 10553
=========================================
Hits ? 23695
Misses ? 17069
Partials ? 4808Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyYAML 5.1 was just released, which doesn't support !include as
previous versions do. This breaks our DTS bindings parsing. Freeze
the PyYAML version in requirements.txt to a known good version to
prevent new installs from breaking.
Reported-by: Andy Doan andy@foundries.io
Reported-by: Michael Scott mike@foundries.io
Signed-off-by: Marti Bolivar marti@foundries.io