drivers/pci: stop using LOG_DBG() #14920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
All checks are passing now. Review history of this comment for details about previous failed status. |
Codecov Report
@@ Coverage Diff @@
## master #14920 +/- ##
=======================================
Coverage 52.92% 52.92%
=======================================
Files 309 309
Lines 45248 45248
Branches 10447 10447
=======================================
Hits 23949 23949
Misses 16533 16533
Partials 4766 4766Continue to review full report at Codecov.
|
dcpleung
approved these changes
Mar 26, 2019
andrewboie
approved these changes
Mar 26, 2019
When the console UART is a PCI device, and PCI debug logging is enabled, the system crashes because the UART is initialized before logging, but the UART initialization invokes the PCI subsystem which invokes logging. Reordering the initialization sequence will not fix this chicken/egg. Luckily, the LOG_DBG() calls in the PCI subsystem appear to be bitrot leftovers from early development, so they are simply removed. Also mark myself as the owner of the PCI subsystem. Fixes: #14763 Signed-off-by: Charles E. Youse <charles.youse@intel.com>
carlescufi
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the console UART is a PCI device, and PCI debug logging is enabled,
the system will crash because the UART is initialized before logging, but
the UART initialization invokes the PCI subsystem which invokes logging.
Reordering the initialization sequence will not fix this chicken-and-egg.
Luckily, the LOG_DBG() calls in the PCI subsystem appear to be bitrot
leftovers from early development, so they are simply removed.
Also mark myself as the owner of the PCI subsystem.
Fixes: #14763
Signed-off-by: Charles E. Youse charles.youse@intel.com