tests: watchdog: Update test to support ATSAMxxxx based board #14968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@overheat : Sorry, but when checkout this pull request and run the test (sam_e70_xplained, f5a4a698ec17e6a78299966a1a3fe73c3404b78d), I get infinite loop on |
overheat
force-pushed
the
fix_test_sam_wdog
branch
from
8fdb1b0 to
bb9909f
Compare
|
According to #15109, ATSAME70 don't preserve RAM when watchdog triggers, which is a kind of chip bug and also cause failure in watchdog test. So exclude this series of chips from this test. |
overheat
force-pushed
the
fix_test_sam_wdog
branch
from
bb9909f to
3d8aea9
Compare
| #elif defined(CONFIG_WDT_SAM) | ||
| #ifdef CONFIG_SOC_SERIES_SAME70 | ||
| #error SAME70 series chip NOT supports this test. | ||
| #endif |
There was a problem hiding this comment.
Is this change is required ? as u are spiking the test by adding the same70 to platform exclude in testcase.yaml file
There was a problem hiding this comment.
@SavinayDharmappa according to #15109. section .noinit be cleared(random) during the boot process on ATSAME70 MCU (SAM E70 Xplained board), this bug comes from the SoC itself and not from Zephyr.
I have adding the same70 to platform exclude in testcase.yaml file.
overheat
force-pushed
the
fix_test_sam_wdog
branch
from
3d8aea9 to
9969331
Compare
|
@nashif @cinlyooi-intel @SavinayDharmappa @ManojSubbarao |
|
Hi, @overheat could you please rebase this one, so we can look at it again? thanks in advance |
|
Sure. For a moment. |
ATSAM watchdog driver does not support callback which is not expected by the test. Update to make testing able to run on ATSAM watchdog drivers. ATSAME70 is NOT support this test, because the RAM is not preserved when the watchdog triggers. Fixes zephyrproject-rtos#13468 Signed-off-by: Aaron Tsui <aaron.tsui@outlook.com>
overheat
force-pushed
the
fix_test_sam_wdog
branch
from
9969331 to
9755ef6
Compare
zephyrbot
added
the
area: Tests
|
the issue was solved in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATSAM watchdog driver does not support callback which is not expected by
the test. Update to make testing able to run on ATSAM watchdog drivers.
Fixes #13468 for Arduino_due and so on.
Signed-off-by: Aaron Tsui aaron.tsui@outlook.com