ethernet: eth_stellaris: data_len should not include header size #15241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue with Stellaris Ethernet driver reported in #13943 |
|
All checks are passing now. Review history of this comment for details about previous failed status. |
jukkar
added
area: Ethernet
area: Networking
bug
jukkar
requested changes
Apr 7, 2019
bravegnu
force-pushed
the
header-fix
branch
2 times, most recently
from
2454a78 to
07a1720
Compare
As part of the ll_reserve refactoring effort, the packet length now includes header size as well. Before the refactor, when the packet length was written to the device, it did not include the header size, which is the required value as per the LM3S6965 datasheet. After the refactor the packet length includes the header size as well. The header size has to subtracted from the packet length before writing to the device. Fixes zephyrproject-rtos#13943. Signed-off-by: Vijay Kumar B <vijaykumar@zilogic.com>
jukkar
approved these changes
Apr 7, 2019
nashif
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ll_reserve refactoring effort, the packet length now
includes header size as well. Before the refactor, when the packet
length was written to the device, it did not include the header size,
which is the required value as per the LM3S6965 datasheet. After the
refactor the packet length includes the header size as well. The
header size has to subtracted from the packet length before writing to
the device.
Fixes #13943
Signed-off-by: Vijay Kumar B. vijaykumar@zilogic.com