net: lwm2m: Publicize firmware block context #16369
Conversation
yaomon
requested review from
jukkar,
mike-scott,
pfalcon and
tbursztyka
as code owners
|
All checks are passing now. Review history of this comment for details about previous failed status. |
|
I apologize for the delay. My work schedule has been very busy and I was away on vacation for the last few weeks. I'm reviewing this now. |
|
I recommended squashing the 2nd patch back into the first, but overall, I wonder if this isn't a situation that the LwM2M subsys should just handle. Why leave it up to the client at all? |
|
@mike-scott What should we do with this, merge or not to merge? |
|
@jukkar don't merge. There is still the open question concerning the 2nd patch. |
|
@yaomon can you move the brace change back into the first patch (so there is only 1 patch)? |
|
Yea, I'll try to get on it ASAP. |
This change is to allow access to the firmware block context in order to give the firmware update callback implementation an indication of when to reset the flash context. Additionally, it allows for a validity check between the total expected size downloaded and the actual size downloaded. A simple implementation can check if the block context's current downloaded blocks is equal to the expected block size in order to determine if the flash context needs to be reset. This approach seemed the simplest, and knowing the firmware block context can have other purposes. This has been tested by accessing the block context during the update in the block received callback and confirming that the callback had information regarding the current downloaded bytes. Fixes #16122 Signed-off-by: Kyle Sun <yaomon18@yahoo.com>
|
Ok, the commits have been squashed. Let me know what else needs to be changed. Thanks for taking the time to respond :) |
|
@yaomon I tagged this for v2.1 as the merge window has been closed for some time on v2.0. Thank you for submitting and fixing the change. |
|
stale, closing. Reopen when there are updates... |
No description provided.