Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: controller: Fixes related to BT LL TS 5.1.0 conformance test run #17097

Merged
merged 8 commits into from
Jul 16, 2019
Merged

Bluetooth: controller: Fixes related to BT LL TS 5.1.0 conformance test run #17097

merged 8 commits into from
Jul 16, 2019

Conversation

cvinayak
Copy link
Contributor

No description provided.

@cvinayak cvinayak added area: Bluetooth bug The issue is a bug, or the PR is fixing a bug backport v1.14-branch labels Jun 26, 2019
@cvinayak cvinayak force-pushed the github_ts_5_1_0_fix branch from b92410a to 72823c2 Compare June 28, 2019 04:55
@cvinayak cvinayak added the DNM This PR should not be merged (Do Not Merge) label Jun 28, 2019
@cvinayak cvinayak force-pushed the github_ts_5_1_0_fix branch from 72823c2 to 8673088 Compare June 28, 2019 13:37
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jun 28, 2019 •
edited
Loading

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

@cvinayak cvinayak force-pushed the github_ts_5_1_0_fix branch from 8673088 to 5ef0eac Compare June 28, 2019 13:43
@cvinayak cvinayak mentioned this pull request Jun 28, 2019
Closed
@cvinayak cvinayak force-pushed the github_ts_5_1_0_fix branch 3 times, most recently from d4745fc to e017d58 Compare July 9, 2019 17:44
@cvinayak cvinayak added this to the v1.14.1 milestone Jul 12, 2019
cvinayak added 8 commits July 15, 2019 21:53
@cvinayak
Bluetooth: controller: Fix PHY update proc symmetric rsp
7c4a071 
Fix PHY update procedure to correctly handle master
requesting asymmetrical and slave symmetrical.

Fixes BT LL TS 5.1.0 conformance test:
LL/CON/MAS/BV-117-C [PHY Update Procedure - Master
Requests Asymmetrical, Slave Symmetrical]

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: controller: Fix packet timing restriction reset
12365e8 
Fixed a bug related to missing reset of packet timing
restriction variable.

Fixes BT LL TS 5.1.0 test:
LL/CON/SLA/BV-55-C [Initiating PHY Update Procedure - Packet
Time Restrictions, LE Coded]

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: controller: Fix missing data length update event
ffc71f2 
Fix missing generation of data length update HCI event when
effective tx and rx timings change due to PHY update
procedure.

Fixes BT LL TS 5.1.0 test:
LL/CON/MAS/BV-52-C [Master Receiving Data, LE Coded, CI
Change]

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: controller: Fix post DLE/PHY update event length
32c2f85 
Fix the controller implementation to perform connection
event length reservation based on the completed Data Length
Update and/or PHY Update Procedure.

This fix with avoid states/roles from stepping on each
others event length. Connection would have supervision timed
out or have stalled data transmissions due to insufficient
reserved air time.

Relates to zephyrproject-rtos#15171.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: controller: Enable Fast Enc and RSSI features
3044da4 
Enable the Fast Encryption design and connection RSSI
measurement when CONFIG_BT_HCI_RAW is selected.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: controller: Add deferred procedure complete event
2bf9d49 
Added implementation to defer procedure complete event until
actual on-air connection event instant.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: controller: Fix DLE during data transmission
ffbbec7 
Fix bug in Data Length Update procedure that caused the
connection to drop due to the implementation sending bigger
PDU before the peer has acknowledged the receipt of Length
Response PDU.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: controller: Update Bluetooth version to 5.1
96cd4af 
Update the Bluetooth HCI Version to 5.1.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak cvinayak force-pushed the github_ts_5_1_0_fix branch from e017d58 to 96cd4af Compare July 15, 2019 16:27
@cvinayak cvinayak removed the DNM This PR should not be merged (Do Not Merge) label Jul 16, 2019
cvinayak added a commit to cvinayak/zephyr that referenced this pull request Jul 16, 2019
@cvinayak
Bluetooth: controller: split: Fix PHY update proc symmetric rsp
2f1f7dd 
Fix PHY update procedure to correctly handle master
requesting asymmetrical and slave symmetrical.

Fixes BT LL TS 5.1.0 conformance test:
LL/CON/MAS/BV-117-C [PHY Update Procedure - Master
Requests Asymmetrical, Slave Symmetrical]

Relates to zephyrproject-rtos#17097.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak cvinayak mentioned this pull request Jul 16, 2019
Merged
cvinayak added a commit to cvinayak/zephyr that referenced this pull request Jul 16, 2019
@cvinayak
Bluetooth: controller: split: Fix packet timing restrict reset
a80dfb8 
Fixed a bug related to missing reset of packet timing
restriction variable.

Fixes BT LL TS 5.1.0 test:
LL/CON/SLA/BV-55-C [Initiating PHY Update Procedure - Packet
Time Restrictions, LE Coded]

Related to zephyrproject-rtos#17097.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak cvinayak mentioned this pull request Jul 16, 2019
Merged
@carlescufi carlescufi merged commit e0965fa into zephyrproject-rtos:master Jul 16, 2019
@backporting
Copy link

backporting bot commented Jul 16, 2019

The backport to v1.14-branch failed:

Commits ["7c4a07166fde6f5c80bf4ab887ec8a72cadbe533","12365e869ec8d2dc2ce3c3cf94bc3ad966d2ae23","ffc71f281ed4c1237bd4854e32dbf8dc914f2658","32c2f850ba2b89449b4571a20b53fc288158b460","3044da4b0a9d87755ea2be95aac49661ef5714f9","2bf9d491ec7c1e797116e408ed319ebb2e76a969","ffbbec7a89ca3e1bea2d646ae92d3c36fd0739c8","96cd4afc04e7b687fde49704e2e1d3714e12d654"] could not be cherry-picked on top of v1.14-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v1.14-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 7c4a07166fde6f5c80bf4ab887ec8a72cadbe533 12365e869ec8d2dc2ce3c3cf94bc3ad966d2ae23 ffc71f281ed4c1237bd4854e32dbf8dc914f2658 32c2f850ba2b89449b4571a20b53fc288158b460 3044da4b0a9d87755ea2be95aac49661ef5714f9 2bf9d491ec7c1e797116e408ed319ebb2e76a969 ffbbec7a89ca3e1bea2d646ae92d3c36fd0739c8 96cd4afc04e7b687fde49704e2e1d3714e12d654
# Create a new branch with these backported commits.
git checkout -b backport-17097-to-v1.14-branch
# Push it to GitHub.
git push --set-upstream origin backport-17097-to-v1.14-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v1.14-branch and the compare/head branch is backport-17097-to-v1.14-branch.

carlescufi pushed a commit that referenced this pull request Jul 17, 2019
@cvinayak @carlescufi
Bluetooth: controller: split: Fix packet timing restrict reset
ae8628d 
Fixed a bug related to missing reset of packet timing
restriction variable.

Fixes BT LL TS 5.1.0 test:
LL/CON/SLA/BV-55-C [Initiating PHY Update Procedure - Packet
Time Restrictions, LE Coded]

Related to #17097.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
carlescufi pushed a commit that referenced this pull request Jul 17, 2019
@cvinayak @carlescufi
Bluetooth: controller: split: Fix PHY update proc symmetric rsp
a081e00 
Fix PHY update procedure to correctly handle master
requesting asymmetrical and slave symmetrical.

Fixes BT LL TS 5.1.0 conformance test:
LL/CON/MAS/BV-117-C [PHY Update Procedure - Master
Requests Asymmetrical, Slave Symmetrical]

Relates to #17097.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
This was referenced Jul 18, 2019
Merged
Merged
cvinayak added a commit to cvinayak/zephyr that referenced this pull request Oct 10, 2019
@cvinayak
Bluetooth: controller: split: Fix missing data len update event
7a50f6f 
Fix missing generation of data length update HCI event when
effective tx and rx timings change due to PHY update
procedure.

Fixes BT LL TS 5.1.0 test:
LL/CON/MAS/BV-52-C [Master Receiving Data, LE Coded, CI
Change]

Relates to zephyrproject-rtos#17097.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
carlescufi pushed a commit that referenced this pull request Oct 10, 2019
@cvinayak @carlescufi
Bluetooth: controller: split: Fix missing data len update event
d12c53f 
Fix missing generation of data length update HCI event when
effective tx and rx timings change due to PHY update
procedure.

Fixes BT LL TS 5.1.0 test:
LL/CON/MAS/BV-52-C [Master Receiving Data, LE Coded, CI
Change]

Relates to #17097.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak cvinayak deleted the github_ts_5_1_0_fix branch March 1, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlescufi carlescufi carlescufi approved these changes

@thoh-ot thoh-ot Awaiting requested review from thoh-ot

Assignees
No one assigned
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
v1.14.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cvinayak @zephyrbot @carlescufi