net: conn: Deliver multicast pkt to all interested parties #18797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we receive a multicast IPv4 or IPv6 packet, then we need to deliver it to all sockets that have installed a handler for it. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
| NET_DBG("[%p] mcast match found cb %p ud %p", | ||
| conn, conn->cb, conn->user_data); | ||
|
|
||
| mcast_pkt = net_pkt_clone(pkt, CLONE_TIMEOUT); |
There was a problem hiding this comment.
Do you think we could do a shallow clone here?
It would save some memory but it's also risky that a receiver would change something in the pkt.
There was a problem hiding this comment.
As we cannot guarantee that the apps won't modify the data, the net_buf needs to be cloned too.
Test requires more network buffers to work properly. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
zephyrbot
added
the
area: Tests
rveerama1
approved these changes
Sep 2, 2019
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v1.14-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick d8dc5446174ac9540d0723e847a6c32218465b34 c004bf735b84ab7e1195153c65df57c0072969ff
# Create a new branch with these backported commits.
git checkout -b backport-18797-to-v1.14-branch
# Push it to GitHub.
git push --set-upstream origin backport-18797-to-v1.14-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backportThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we receive a multicast IPv4 or IPv6 packet, then we need to
deliver it to all sockets that have installed a handler for it.
Signed-off-by: Jukka Rissanen jukka.rissanen@linux.intel.com