arm: arch code naming cleanup #19491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewboie
requested review from
galak,
ioannisg and
MaureenHelm
as code owners
zephyrbot
added
area: Timer
|
All checks passed. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
andrewboie
force-pushed
the
arm-arch-renaming
branch
5 times, most recently
from
52be732 to
613fc3c
Compare
zephyrbot
added
the
area: Tests
ioannisg
reviewed
Oct 2, 2019
ioannisg
reviewed
Oct 2, 2019
ioannisg
reviewed
Oct 2, 2019
ioannisg
reviewed
Oct 2, 2019
ioannisg
reviewed
Oct 2, 2019
ioannisg
requested changes
Oct 2, 2019
There was a problem hiding this comment.
Mostly ok, thanks @andrewboie
I left some comments in the review
andrewboie
force-pushed
the
arm-arch-renaming
branch
from
613fc3c to
f256835
Compare
This patch re-namespaces global variables and functions that are used only within the arch/arm/ code to be prefixed with z_arm_. Some instances of CamelCase have been corrected. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
andrewboie
force-pushed
the
arm-arch-renaming
branch
from
f256835 to
b2370d2
Compare
|
@ioannisg updated, thanks for reviewing |
ioannisg
approved these changes
Oct 3, 2019
|
Changes log is trivial, but huge. I wonder @galak @MaureenHelm if you would like to take a look. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch re-namespaces global variables and functions
that are used only within the arch/arm/ code to be
prefixed with z_arm_.
Some instances of CamelCase have been corrected.
Signed-off-by: Andrew Boie andrew.p.boie@intel.com