Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drivers: watchdog: exclude platforms with SAM WDT from testing #21008

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

ioannisg
Copy link
Member

On watchdog-triggered reboot, the SAM platforms
reset RAM, so the wdt_basic_api cannot be completed
successfully, as it relies on RAM retention (relies
on variables stored in RAM retaining their values
across different boot cycles). Exclude the platforms
with the SAM Watchdog from this test.

Signed-off-by: Ioannis Glaropoulos Ioannis.Glaropoulos@nordicsemi.no

Fixes #13417

On watchdog-triggered reboot, the SAM platforms
reset RAM, so the wdt_basic_api cannot be completed
successfully, as it relies on RAM retention (relies
on variables stored in RAM retaining their values
across different boot cycles). Exclude the platforms
with the SAM Watchdog from this test.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
@ioannisg ioannisg requested a review from nashif as a code owner November 26, 2019 16:35
@ioannisg ioannisg requested a review from MaureenHelm November 26, 2019 16:35
@ioannisg ioannisg added platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Nov 26, 2019
@ioannisg ioannisg added this to the v2.1.0 milestone Nov 26, 2019
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Nov 26, 2019
@ioannisg ioannisg added the bug The issue is a bug, or the PR is fixing a bug label Nov 27, 2019
@ioannisg ioannisg requested a review from dleach02 November 27, 2019 16:12
Copy link
Collaborator

@aurel32 aurel32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is the correct way to fix the issue, at least as long as the test requires that RAM is left unchanged upon a watchdog reset.

@nashif nashif merged commit c8b0b1a into zephyrproject-rtos:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/drivers/watchdog/wdt_basic_api/testcase.yaml: test_wdt_no_callback() failed at "Waiting to restart MCU"
5 participants