cmake: toolchain: Don't add -Werror=implicit-int to CXX builds #21242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do compiler flag compatibility tests to be able to support many different toolchains and flags in a scalable way. But the test is not perfect and in these situations we we will need to hardcode whether a flag is compatible or not. To support this we have zephyr_compiler_check first check if the flag is covered by a hardcoded test before testing it. Currently the only hardcoded compatibilty is that -Werror=implicit-int is not supported for CXX. This fixes zephyrproject-rtos#21229 Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
SebastianBoe
added
area: Build System
area: Configuration System
area: Portability
pabigot
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do compiler flag compatibility tests to be able to support many
different toolchains and flags in a scalable way. But the test is not
perfect and in these situations we we will need to hardcode whether a
flag is compatible or not.
To support this we have zephyr_compiler_check first check if the flag
is covered by a hardcoded test before doing an automatic test.
Currently the only hardcoded compatibilty is that -Werror=implicit-int
is not supported for CXX.
This fixes #21229
Signed-off-by: Sebastian Bøe sebastian.boe@nordicsemi.no