Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: fix removal of needed subscriptions #21377

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

marcoster
Copy link
Contributor

@marcoster marcoster commented Dec 13, 2019

Providing 'tmp', which was never updated, resulted in removeal of
subscriptions from the beginning.
Using the updated 'prev' resolves this.

Fixes #21375

Signed-off-by: Marco Sterbik madbadmax00@gmail.com

Providing 'tmp', which was never updated, resulted in removeal of
subscriptions from the beginning.
Using the updated 'prev' resolves this.

Signed-off-by: Marco Sterbik <madbadmax00@gmail.com>
Copy link
Contributor

@joerchan joerchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct and in line with how the other FOREACH loops do it.

@joerchan joerchan added the bug The issue is a bug, or the PR is fixing a bug label Dec 20, 2019
Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need back porting to 1.14? @Vudentz could you take a look as well?

Copy link
Contributor

@Vudentz Vudentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vudentz Vudentz added the Backport Backport PR and backport failure issues label Dec 30, 2019
@Vudentz
Copy link
Contributor

Vudentz commented Dec 30, 2019

Does this need back porting to 1.14? @Vudentz could you take a look as well?

Yep, this should be backported.

@jhedberg jhedberg merged commit 9217c66 into zephyrproject-rtos:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Backport Backport PR and backport failure issues bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GATT: gatt_write_ccc_rsp with error (0x0e) removes always beginning from subscriptions head
5 participants