cmake: toolchain: generalize exclusion of CXX options #21398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
|
||
| # List the warnings that are not supported for C++ compilations | ||
|
|
||
| set(CXX_EXCLUDED_OPTIONS |
There was a problem hiding this comment.
list(APPEND
then it could be populated elsewhere as well.
SebastianBoe
approved these changes
Dec 16, 2019
pabigot
force-pushed
the
pabigot/20191214b
branch
from
44311eb to
55c4f32
Compare
| @@ -854,7 +854,7 @@ function(zephyr_check_compiler_flag_hardcoded lang option check exists) | |||
| # -Werror=implicit-int is not supported for CXX and we are not able | |||
| # to automatically test for it because it produces a warning | |||
| # instead of an error during the test. | |||
| if((${lang} STREQUAL CXX) AND ("${option}" STREQUAL -Werror=implicit-int)) | |||
| if((${lang} STREQUAL CXX) AND ("${option}" IN_LIST CXX_EXCLUDED_OPTIONS)) | |||
There was a problem hiding this comment.
# -Werror=implicit-int and other flags in CXX_EXCLUDED_OPTIONS are not supported for CXX and we are not able
Sorry for the stepwise feedback.
There was a problem hiding this comment.
Is the new wording OK? I didn't want to mention specific flags because they might not apply to certain toolchains.
-Wold-style-definition is not a supported option for C++ builds. To prevent it being passed: * the list of compiler flags to be excluded from C++ builds is moved to be toolchain-specific; * -Wold-style-definition is added to that list for gcc and clang; * -Wold-style-definition is moved from zephyr_compiler_options to zephyr_cc_option so the option checking code is executed for it. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
pabigot
force-pushed
the
pabigot/20191214b
branch
from
55c4f32 to
269bb2f
Compare
carlescufi
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wold-style-definitionis not a supported option for C++ builds. To prevent it being passed:-Wold-style-definitionis added to that list for gcc and clang;-Wold-style-definitionis moved fromzephyr_compiler_optionstozephyr_cc_optionso the option checking code is executed for it.Fixes #16239