Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPIC-GPIO] drivers: sensor: bmi160: convert to new GPIO API #21582

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

pabigot
Copy link
Collaborator

@pabigot pabigot commented Dec 23, 2019

NOTE This is untested as there is no sample, the driver only supports the SPI interface, and the breakout that I have and the neonkey that has it on-board only support I2C.

Document interrupt signal and replace legacy calls with new API.

Document interrupt signal and replace legacy calls with new API.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
@pabigot pabigot changed the title drivers: sensor: bmi160: convert to new GPIO API [TOPIC-GPIO] drivers: sensor: bmi160: convert to new GPIO API Dec 29, 2019
@zephyrbot zephyrbot closed this Jan 3, 2020
@zephyrbot zephyrbot reopened this Jan 3, 2020
@zephyrbot
Copy link
Collaborator

Some checks failed. Please fix and resubmit.

Documentation issues

/var/lib/shippable/build/IN/main_repo/zephyr/doc/_build/rst/doc/reference/file_system/index.rst:58: WARNING: Duplicate declaration, fs_statvfs
/var/lib/shippable/build/IN/main_repo/zephyr/doc/_build/rst/doc/reference/networking/net_if.rst:61: WARNING: Duplicate declaration, struct net_if_addr* net_if_ipv6_addr_lookup(const struct  in6_addr  * addr, struct  net_if  ** iface)
/var/lib/shippable/build/IN/main_repo/zephyr/doc/_build/rst/doc/reference/networking/net_if.rst:61: WARNING: Duplicate declaration, struct net_if_mcast_addr* net_if_ipv6_maddr_lookup(const struct  in6_addr  * addr, struct  net_if  ** iface)
/var/lib/shippable/build/IN/main_repo/zephyr/doc/_build/rst/doc/reference/networking/net_if.rst:61: WARNING: Duplicate declaration, struct net_if_addr* net_if_ipv4_addr_lookup(const struct  in_addr  * addr, struct  net_if  ** iface)
/var/lib/shippable/build/IN/main_repo/zephyr/doc/_build/rst/doc/reference/networking/net_if.rst:61: WARNING: Duplicate declaration, bool net_if_ipv4_addr_mask_cmp(struct  net_if  * iface, const struct  in_addr  * addr)
/var/lib/shippable/build/IN/main_repo/zephyr/doc/_build/rst/doc/reference/networking/net_if.rst:61: WARNING: Duplicate declaration, bool net_if_ipv4_is_addr_bcast(struct  net_if  * iface, const struct  in_addr  * addr)
/var/lib/shippable/build/IN/main_repo/zephyr/doc/_build/rst/doc/reference/networking/net_if.rst:61: WARNING: Duplicate declaration, net_if_mcast_monitor
/var/lib/shippable/build/IN/main_repo/zephyr/doc/_build/rst/doc/reference/peripherals/dma.rst:13: WARNING: Duplicate declaration, dma_config

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@MaureenHelm
Copy link
Member

@pabigot any idea what's up with the doc warnings? does the topic-gpio branch need rebasing?

@pabigot
Copy link
Collaborator Author

pabigot commented Jan 3, 2020

@pabigot any idea what's up with the doc warnings? does the topic-gpio branch need rebasing?

@MaureenHelm Don't know about the doc warnings, but the topic branch is way out of date, last rebase was 2019-11-13, two weeks before 2.1. Once everybody's back there's a lot of maintenance that needs to be done; there will be conflicts (I tried it a week or two ago just to see).

@carlescufi
Copy link
Member

Merging since there are no changes to doc and this is probably due to a required rebase.

@carlescufi carlescufi merged commit 2cf75c6 into zephyrproject-rtos:topic-gpio Jan 9, 2020
@pabigot
Copy link
Collaborator Author

pabigot commented Jan 9, 2020

@carlescufi Actually this was the one we discussed in TSC yesterday; I was going to mark it DNM until we have a documented mechanism to identify unmaintained sensors. And some consensus on what "unmaintained" means. I was tending towards "has been modified but left untested".

@pabigot pabigot deleted the gpio/bmi160 branch January 16, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants