-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[topic-gpio] drivers: hmc5883l: update to new GPIO API #21718
[topic-gpio] drivers: hmc5883l: update to new GPIO API #21718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the binding file to describe the active level of the signal so people don't have to guess whether the sensor/driver is providing/expecting active low. See for example https://github.com/pabigot/zephyr/blob/286518ef1f79688524f7cc88d9073a1c95936de2/dts/bindings/sensor/st%2Chts221.yaml#L20
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally we've been putting all changes related to the new API into a single commit, rather than breaking out the binding description from the driver support.
I can merge these both into a single commit, just wanted to see if the description was sufficient or not. |
This commit updates the HMC5883L driver to use the new GPIO API. Also add a note explicitly describing the active state of the DRDY pin in the binding file. Tested on frdm_k64f. Signed-off-by: Kevin Townsend <kevin@ktownsend.com>
I merged them into one commit in the rebase. |
This commit updates the HMC5883L driver to use the new GPIO API.
Tested on frdm_k64f.
Signed-off-by: Kevin Townsend kevin.townsend@linaro.org