Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[topic-gpio] drivers: hmc5883l: update to new GPIO API #21718

Merged

Conversation

microbuilder
Copy link
Member

This commit updates the HMC5883L driver to use the new GPIO API.

Tested on frdm_k64f.

Signed-off-by: Kevin Townsend kevin.townsend@linaro.org

Copy link
Collaborator

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the binding file to describe the active level of the signal so people don't have to guess whether the sensor/driver is providing/expecting active low. See for example https://github.com/pabigot/zephyr/blob/286518ef1f79688524f7cc88d9073a1c95936de2/dts/bindings/sensor/st%2Chts221.yaml#L20

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 6, 2020

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@microbuilder
Copy link
Member Author

Please update the binding file to describe the active level of the signal so people don't have to guess whether the sensor/driver is providing/expecting active low. See for example https://github.com/pabigot/zephyr/blob/286518ef1f79688524f7cc88d9073a1c95936de2/dts/bindings/sensor/st%2Chts221.yaml#L20

ffd6448

@pabigot pabigot self-requested a review January 6, 2020 14:47
Copy link
Collaborator

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we've been putting all changes related to the new API into a single commit, rather than breaking out the binding description from the driver support.

@microbuilder
Copy link
Member Author

Generally we've been putting all changes related to the new API into a single commit, rather than breaking out the binding description from the driver support.

I can merge these both into a single commit, just wanted to see if the description was sufficient or not.

This commit updates the HMC5883L driver to use the new GPIO API.

Also add a note explicitly describing the active state of the DRDY
pin in the binding file.

Tested on frdm_k64f.

Signed-off-by: Kevin Townsend <kevin@ktownsend.com>
@galak
Copy link
Collaborator

galak commented Jan 17, 2020

I can merge these both into a single commit, just wanted to see if the description was sufficient or not.

I merged them into one commit in the rebase.

@carlescufi carlescufi changed the title drivers: hmc5883l: update to new GPIO API [topic-gpio] drivers: hmc5883l: update to new GPIO API Jan 17, 2020
@carlescufi carlescufi merged commit 8549310 into zephyrproject-rtos:topic-gpio Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants