drivers: ieee802154: rf2xx: Add missing handle_ack call #21773
Conversation
The rf2xx driver is doing automatic retransmissions in hardware based on whether ACKs are received or not. Currently the driver is not invoking ieee802154_radio_handle_ack() as other drivers are doing and required by OpenThread since 4fe1da9. This add rf2xx_handle_ack method to ensures required ACK processing when driver performs TX. Fixes: zephyrproject-rtos#21763 Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
nandojve
changed the title
Easiest is just to re-trigger CI tests so closing and then re-opening the PR is enough. |
|
Hi Folks, I added DNM because I don't have a full setup to test OT yet, sorry about not comment about it. I'll start to create setup this weeek I hope test this ASAP. After applying @tbursztyka tips I believe solution is ready, but need test first. @markus-becker-tridonic-com could you describe your setup so I can reproduce my own to test OT? Any tip how to create one and configure is welcome. You can find me at zephyrproject.slack.com too. PS.: I have 2 - PCA10056 that may help and one Wireshark Sniffer. |
|
Adding also DNM label. Remember to remove the label after the PR is ready to be merged. |
|
@nandojve my test set-up is the Tridonic Thread BR based on mbed, but it should also work with a Nordic dev board BR based on OT: https://openthread.io/guides/border-router . |
|
ping @nandojve / @markus-becker-tridonic-com Is this PR ready for merge? |
Hello @jukkar, sorry for my delay. @markus-becker-tridonic-com did tests and report success at #21763. With this we fixed the issue and I'm removing DNM from PR Label. It's ready to be merged! Thank you everyone for helping with this! |
nandojve
changed the title
The rf2xx driver is doing automatic retransmissions in hardware based
on whether ACKs are received or not. Currently the driver is not
invoking ieee802154_radio_handle_ack() as other drivers are doing and
required by OpenThread since 4fe1da9. This add rf2xx_handle_ack method
to ensures required ACK processing when driver performs TX.
Fixes: #21763
Signed-off-by: Gerson Fernando Budke nandojve@gmail.com