i2c: add i2c shell with scan cmd #21797
Conversation
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
drivers/i2c/i2c_shell.c
Outdated
|
|
||
| #define LOG_LEVEL CONFIG_LOG_DEFAULT_LEVEL | ||
| #include <logging/log.h> | ||
| LOG_MODULE_REGISTER(i2c_shell); |
There was a problem hiding this comment.
can be shorten to LOG_MODULE_REGISTER(i2c_shell, CONFIG_LOG_DEFAULT_LEVEL);
drivers/i2c/i2c_shell.c
Outdated
| } | ||
|
|
||
| SHELL_STATIC_SUBCMD_SET_CREATE(sub_i2c_cmds, | ||
| /* Alphabetically sorted. */ |
There was a problem hiding this comment.
As far as I remember you do no need to sort sub-commands any more
There was a problem hiding this comment.
copy pasted from another shell :)
drivers/i2c/i2c_shell.c
Outdated
| ); | ||
|
|
||
| SHELL_STATIC_SUBCMD_SET_CREATE(sub_i2c, | ||
| #ifdef CONFIG_I2C_0 |
There was a problem hiding this comment.
This is good approach.
In future we can think of implementing this as a dynamic commands. All active I2C instances can be collected in runtime.
There was a problem hiding this comment.
tried to do that similar to how it was done in the sensor shell, but something did not work for me, so I reverted to this.
There was a problem hiding this comment.
changed and implemented dynamic device detection...
nashif
force-pushed
the
i2c_shell_scan
branch
2 times, most recently
from
687430b to
718c362
Compare
| entry->help = NULL; | ||
| entry->subcmd = &dsub_device_name; | ||
|
|
||
| for (dev = __device_init_start; dev != __device_init_end; dev++) { |
There was a problem hiding this comment.
ha ha, that is the same as device_get_by_prefix
There was a problem hiding this comment.
yes, we definitely need something like that in some form, I see this code being duplicated all over the place.
There was a problem hiding this comment.
For example, it would be great to have the "on-bus" from dts somewhere in the device structure so we can filter based on a bus.
Now part of the I2C shell and works for all boards. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Add a shell to interact with I2C devices. Currently scanning for devices
is supported. Example output:
uart:~$ i2c scan I2C_1
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- -- -- -- -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- 18 -- -- -- -- -- -- --
20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: 40 -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
70: -- -- -- -- -- -- -- --
2 devices found on I2C_1
uart:~$ i2c scan I2C_3
i2c - I2C commands
Subcommands:
I2C_1 :I2C_1
I2C_2 :I2C_2
uart:~$ i2c scan I2C_2
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- -- -- -- -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- 1e --
20: -- -- -- -- -- -- -- -- -- 29 -- -- -- 2d -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
50: -- -- -- -- -- -- 56 -- -- -- -- -- -- 5d -- 5f
60: -- -- -- -- -- -- -- -- -- -- 6a -- -- -- -- --
70: -- -- -- -- -- -- -- --
7 devices found on I2C_2
This shell is based on the a sample that did the same thing and was
limited in support. The sample is now removed in favour of this generic
shell module.
Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
i2c_shell_scan
branch
from
718c362 to
9a2e6f8
Compare
|
Wonderful. Presumably this is samples/subsys/shell/shell_module? Is this supposed to work? For anybody else just trying to get their job done, options are revert 7c9a87a locally, or (for Nordic at least) add these to the Then ignore the cascade of errors that show up for all the addresses that don't have a device on it. Reverting is a lot easier. |
Add a shell to interact with I2C devices. Currently scanning for devices is
supported. Example output:
This replaces a dedicated sample that did the same thing.