kconfig: Show unsatisfied deps. when assignments don't take #22052
Conversation
ulfalizer
changed the title
|
Builds on #22043. Please merge that one first, in case I update it. I'll then rebase this PR. |
ulfalizer
force-pushed
the
show-unsatisfied-deps
branch
from
a6e2de3 to
30ea081
Compare
| # on 'sym' (which can also come from e.g. a surrounding 'if'), returns a | ||
| # list of all <expr>s with a value less than the value 'sym' was assigned | ||
| # ("less" instead of "not equal" just to be general and handle tristates, | ||
| # even though Zephyr doesn't use them). |
There was a problem hiding this comment.
"a value less than", does this means we won't be warned of an unsatisfied symbol when we have
depends on ! A
?
There was a problem hiding this comment.
Ah, the expr itself is less than. This should be OK then.
There was a problem hiding this comment.
Does this behave sanely when there are multiple config declarations with different dependencies, thereby creating a "super-config" with each config's dependencies OR'd together?
There was a problem hiding this comment.
It will work at least, though it might require some more manual investigation depending on how the dependencies look.
Might get Check these unsatisfied dependencies: FOO || BAR || BAZ (=n), ... for example. The code always just splits on AND here.
There was a problem hiding this comment.
Forgot to mention: Symbol.direct_dep has the OR of all the dependencies when a symbol is defined in multiple locations.
There was a problem hiding this comment.
Ah, the expr itself is less than. This should be OK then.
Yeah, the way it avoids ever warning for CONFIG_FOO=n is because the dependencies can never be less than n. Avoids special-casing it.
There was a problem hiding this comment.
Might get
Check these unsatisfied dependencies: FOO || BAR || BAZ (=n), ...for example.
Nit on this: I think it might be clearer if the expression is parenthetized, so it's clear the (=n) refers to the whole thing.
There was a problem hiding this comment.
Done. Now puts () around expressions that aren't plain symbols:
Check these unsatisfied dependencies: BAR (=n), BAZ (=n), (BAZ || BAZ) (=n), (STR = "hmm") (=n)
(Added a BAZ || BAZ dependency just to test.)
There was a problem hiding this comment.
As a side note, it'll always be (=n) in Zephyr, but it could be (=m) in projects that use tristate symbols (used for modules in Linux). Doesn't hurt to show it at least.
ulfalizer
force-pushed
the
show-unsatisfied-deps
branch
2 times, most recently
from
57c248b to
d6e5405
Compare
Show which dependencies are unsatisfied when symbols don't get their
assigned value.
For example, assume that FOO below is assigned with CONFIG_FOO=y. Note
that BAR, BAZ, and STR = "hmm" are 'n'.
config FOO
bool "foo"
depends on BAR && BAZ && QAZ && STR = "hmm"
config BAR
def_bool n
config BAZ
def_bool n
config QAZ
def_bool y
config STR
def_string "zmh"
This now prints this warning:
warning: FOO (defined at /home/ulf/z/z/Kconfig:10) was assigned the
value 'y' but got the value 'n'. Check these unsatisfied
dependencies: BAR (=n), BAZ (=n), STR = "hmm" (=n). See ...
Fixes: zephyrproject-rtos#21888
Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
ulfalizer
force-pushed
the
show-unsatisfied-deps
branch
from
d6e5405 to
f830cf8
Compare
|
@oyvindronningstad @SebastianBoe |
Show which dependencies are unsatisfied when symbols don't get their
assigned value.
For example, assume that FOO below is assigned with CONFIG_FOO=y. Note
that BAR, BAZ, and STR = "hmm" are 'n'.
This now prints this warning:
Fixes: #21888