Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPIC-GPIO] drivers: sensor: bma280: convert to new GPIO API #22104

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

pabigot
Copy link
Collaborator

@pabigot pabigot commented Jan 22, 2020

Use the new pin and interrupt configuration API.

NOTE: Because hardware is not available this has been build-tested only.

NOTE: This PR includes #22103 along with a dummy sample used for testing. The only commit that should be merged is the one titled: "drivers: sensor: bma280: convert to new GPIO API". The PR will be marked DNM until the topic branch is rebased on a master that includes #22103.

@pabigot pabigot added the DNM This PR should not be merged (Do Not Merge) label Jan 22, 2020
@zephyrbot zephyrbot added area: Devicetree area: Sensors Sensors area: Samples Samples area: Tests Issues related to a particular existing or missing test labels Jan 22, 2020
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 22, 2020

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@pabigot pabigot changed the title drivers: sensor: bma280: convert to new GPIO API [TOPIC-GPIO] drivers: sensor: bma280: convert to new GPIO API Jan 23, 2020
@pabigot pabigot removed the DNM This PR should not be merged (Do Not Merge) label Jan 26, 2020
drivers/sensor/bma280/bma280_trigger.c Outdated Show resolved Hide resolved
drivers/sensor/bma280/bma280_trigger.c Outdated Show resolved Hide resolved
@pabigot pabigot force-pushed the gpio/bma280 branch 2 times, most recently from 46f3efe to 24dc1e7 Compare January 28, 2020 11:16
@pabigot
Copy link
Collaborator Author

pabigot commented Jan 28, 2020

Shippable failed on qemu_x86_64:samples/userspace/shared_mem/sample.kernel.memory_protection.shared_mem see comments in #21317. This should not block merge.


gpio_pin_interrupt_configure(data->gpio,
DT_INST_0_BOSCH_BMA280_INT1_GPIOS_PIN,
DT_INST_0_BOSCH_BMA280_INT1_GPIOS_FLAGS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you passing in the DT flags here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because whatever sample I coped that boilerplate from did that. I'll look through the existing conversions for that error when I do the other conversions. Fixed here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Use the new pin and interrupt configuration API.

NOTE: Because hardware is not available this has been build-tested
only.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
@MaureenHelm MaureenHelm requested a review from mnkp January 28, 2020 14:23
@carlescufi carlescufi merged this pull request into zephyrproject-rtos:topic-gpio Jan 28, 2020
@pabigot pabigot deleted the gpio/bma280 branch February 1, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree area: Samples Samples area: Sensors Sensors area: Tests Issues related to a particular existing or missing test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants