-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOPIC-GPIO] drivers: sensor: bma280: convert to new GPIO API #22104
Conversation
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
46f3efe
to
24dc1e7
Compare
Shippable failed on qemu_x86_64:samples/userspace/shared_mem/sample.kernel.memory_protection.shared_mem see comments in #21317. This should not block merge. |
|
||
gpio_pin_interrupt_configure(data->gpio, | ||
DT_INST_0_BOSCH_BMA280_INT1_GPIOS_PIN, | ||
DT_INST_0_BOSCH_BMA280_INT1_GPIOS_FLAGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you passing in the DT flags here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably because whatever sample I coped that boilerplate from did that. I'll look through the existing conversions for that error when I do the other conversions. Fixed here.
Use the new pin and interrupt configuration API. NOTE: Because hardware is not available this has been build-tested only. Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
Use the new pin and interrupt configuration API.
NOTE: Because hardware is not available this has been build-tested only.
NOTE: This PR includes #22103 along with a dummy sample used for testing. The only commit that should be merged is the one titled: "drivers: sensor: bma280: convert to new GPIO API". The PR will be marked DNM until the topic branch is rebased on a master that includes #22103.