sanitycheck: add option to allow re-running single tests multiple times #22147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulfalizer
reviewed
Jan 24, 2020
scripts/sanitycheck
Outdated
| count = 0 | ||
| passed = 0 | ||
| failed = 0 | ||
| while count < self.rerun: |
There was a problem hiding this comment.
Could simplify to
for count in range(self.rerun):
...There was a problem hiding this comment.
run_i and self.n_reruns or the like might be clearer naming.
scripts/sanitycheck
Outdated
| self.run() | ||
| self.instance.status, _ = self.instance.handler.get_state() | ||
| if self.instance.status in ['failed', 'timeout']: | ||
| failed = failed + 1 |
There was a problem hiding this comment.
Could do failed += 1. Python has +=.
scripts/sanitycheck
Outdated
| if self.instance.status in ['failed', 'timeout']: | ||
| failed = failed + 1 | ||
| else: | ||
| passed = passed + 1 |
Using --number-of-runs <int> we now can run a single test multiple times to test for reproducibility and to catch sporadic failures. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
github-actions
bot
added
has-conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using --number-of-runs we now can run a single test multiple times
to test for reproducibility and to catch sporadic failures.
The output looks like this: