Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOPIC-GPIO]: Convert LMP90xxx ADC and GPIO drivers to new GPIO API #22212

Merged
merged 3 commits into from
Jan 28, 2020
Merged

[TOPIC-GPIO]: Convert LMP90xxx ADC and GPIO drivers to new GPIO API #22212

merged 3 commits into from
Jan 28, 2020

Conversation

henrikbrixandersen
Copy link
Member

Convert both the GPIO controller part and the GPIO consumer (interrupt consumer) part of the TI LMP90xxx drivers to use the new GPIO API.

@galak galak mentioned this pull request Jan 26, 2020
Closed
@zephyrbot zephyrbot added area: ADC Analog-to-Digital Converter (ADC) area: Boards area: API Changes to public APIs labels Jan 26, 2020
pabigot
pabigot approved these changes Jan 27, 2020
View reviewed changes
Copy link
Collaborator

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok. Have you tested gpio_basic_api and gpio_api_1pin?

drivers/gpio/gpio_lmp90xxx.c Outdated Show resolved Hide resolved
@henrikbrixandersen henrikbrixandersen force-pushed the topic-gpio-lmp90xxx branch 2 times, most recently from f748d42 to ba7d093 Compare January 27, 2020 19:15
@henrikbrixandersen
boards: shields: lmp90100_evb: add ngpios to dts
d16d786 
Add ngpios device tree property to the GPIO controller node of the
LMP90100 EVB shield.

Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
@henrikbrixandersen
drivers: gpio: lmp90xxx: update to use new GPIO API
fdde3e5 
Update the TI LMP90xxx GPIO driver to the new GPIO API.

Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
@henrikbrixandersen
drivers: adc: lmp90xxx: update to use new GPIO API
2ee183d 
Update the DRDYB pin interrupt handling code of the TI LMP90xxx ADC
driver to use the new GPIO API.

Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
@henrikbrixandersen
Copy link
Member Author

This seems ok. Have you tested gpio_basic_api and gpio_api_1pin?

@pabigot Yes. Both pass.

@pabigot pabigot merged this pull request into zephyrproject-rtos:topic-gpio Jan 28, 2020
@henrikbrixandersen henrikbrixandersen deleted the topic-gpio-lmp90xxx branch February 5, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnkp mnkp mnkp left review comments

@pabigot pabigot pabigot approved these changes

@carlescufi carlescufi carlescufi approved these changes

@anangl anangl Awaiting requested review from anangl

@erwango erwango Awaiting requested review from erwango

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

Assignees
No one assigned
Labels
area: ADC Analog-to-Digital Converter (ADC) area: API Changes to public APIs area: Boards area: GPIO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@henrikbrixandersen @pabigot @carlescufi @mnkp @zephyrbot