Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: clock_control: Add subsys argument to the callback #22425

Merged

Conversation

nordic-krch
Copy link
Contributor

Added subsys argument to the callback, updated one driver which
used it and test cases.

Fixes #22424.

Signed-off-by: Krzysztof Chruscinski krzysztof.chruscinski@nordicsemi.no

@nordic-krch nordic-krch added the Breaking API Change Breaking changes to stable, public APIs label Feb 3, 2020
@zephyrbot zephyrbot added area: API Changes to public APIs area: Tests Issues related to a particular existing or missing test labels Feb 3, 2020
@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 3, 2020

All checks passed.

checkpatch (informational only, not a failure)

-:101: WARNING:NEW_TYPEDEFS: do not add new typedefs
#101: FILE: include/drivers/clock_control.h:55:
+typedef void *clock_control_subsys_t;

- total: 0 errors, 1 warnings, 120 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlescufi carlescufi added the Release Notes To be mentioned in the release notes label Feb 3, 2020
Added subsys argument to the callback, updated one driver which
used it and test cases.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Mentioned that callback has one additional parameter (subsys).

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@carlescufi carlescufi merged commit 8df133e into zephyrproject-rtos:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: Documentation area: Sensors Sensors area: Tests Issues related to a particular existing or missing test Breaking API Change Breaking changes to stable, public APIs Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: API Change: clock_control
5 participants