arch: arm: aarch64: linker.ld: Fix ROM section names #22673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2020
Merged
carlocaione
approved these changes
Feb 10, 2020
|
@stephanosio could you rebase? There seems to some conflict with |
andrewboie
approved these changes
Feb 11, 2020
This commit cleans-up the linker.ld file for the AArch64 arch. * Convert all TAB characters to SPACE. * Fix insane placement of curly brackets. * Fix overall text alignments. * Remove the special handlings for the Cortex-M devices that were copied from `include/arm/aarch32/cortex_m/scripts/linker.ld`. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
This commit fixes the improper naming of the ROM sections. 1. Rename the first ROM section, which was previously named using the `_TEXT_SECTION_NAME` definition, to `rom_start`, as this section does not actually represent the text section. 2. Rename the second ROM section, which was previously named `_TEXT_SECTION_NAME_2` which supposedly refers to the definition of the same name that does not exist, to `_TEXT_SECTION_NAME`. Note that this is indeed the section that contains the text section from the source image. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
This commit relocates the `_vector_end` symbol that was previously placed after the OpenOCD sections to before these sections, as the OpenOCD debug sections are not part of the "vector table." Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
stephanosio
force-pushed
the
aarch64_fix_rom_section_names
branch
from
dd4bdc5 to
6363187
Compare
|
Rebased |
ioannisg
approved these changes
Feb 12, 2020
Abhishek-brcm
added a commit
to Broadcom/zephyr
that referenced
this pull request
Feb 20, 2020
Following changes are done: - The vector table should be placed in text segment. - Removed Vector relay table related entries as it is only applicable to aarch32. - irq_vector_table contains ISR pointers - should be placed in rodata segment. - put openocd_dbg in rodata and skip adding <linker_relocate.ld> as CONFIG_CODE_DATA_RELOCATION is not defined for aarch64 currently (add later if needed). Fixes: zephyrproject-rtos#22673 Signed-off-by: Abhishek Shah <abhishek.shah@broadcom.com>
jhedberg
pushed a commit
that referenced
this pull request
Feb 20, 2020
Following changes are done: - The vector table should be placed in text segment. - Removed Vector relay table related entries as it is only applicable to aarch32. - irq_vector_table contains ISR pointers - should be placed in rodata segment. - put openocd_dbg in rodata and skip adding <linker_relocate.ld> as CONFIG_CODE_DATA_RELOCATION is not defined for aarch64 currently (add later if needed). Fixes: #22673 Signed-off-by: Abhishek Shah <abhishek.shah@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the improper naming of the ROM sections.
Rename the first ROM section, which was previously named using the
_TEXT_SECTION_NAMEdefinition, torom_start, as this section doesnot actually represent the text section.
Rename the second ROM section, which was previously named
_TEXT_SECTION_NAME_2which supposedly refers to the definition ofthe same name that does not exist, to
_TEXT_SECTION_NAME. Note thatthis is indeed the section that contains the text section from the
source image.
Signed-off-by: Stephanos Ioannidis root@stephanos.io