Bluetooth: controller: split: Fix radio in use during flash op #22946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a race condition in radio abort requested by flash driver. It is possible that during abort function execution, PPI setup to start radio fires. Hence, check explicitly in cleanup function for radio being in use and disable it. Fixes zephyrproject-rtos#22945. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
added
bug
Fix ticker resolve collision implementation for incorrect ticks accumulation and the calculation of next period. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
jhedberg
approved these changes
Feb 20, 2020
|
Is #22926 related to this? (it also deals with Bluetooth + flash coexistence) |
thoh-ot
previously requested changes
Feb 20, 2020
|
Ticker fixes are related, when the radio assert is handled, the flashing times out as ticker is not scheduling both the connection and flash instances. There is periodic Worker and Job executions but both the instances are skipped always.
And this leads to: |
mtpr-ot
reviewed
Feb 20, 2020
| /* Accumulate ticks_to_expire for each node */ | ||
| acc_ticks_to_expire += ticker_next->ticks_to_expire; | ||
| if (acc_ticks_to_expire > ticker->ticks_slot) { | ||
| break; |
There was a problem hiding this comment.
Am I right in saying that this is an optimization - breaking here? (instead of possibly traversing more tickers)
mtpr-ot
reviewed
Feb 20, 2020
| @@ -1400,8 +1402,9 @@ static inline void ticker_job_worker_bh(struct ticker_instance *instance, | |||
| /* Reload ticks_to_expire with one period */ | |||
| ticker->ticks_to_expire = | |||
| ticker->ticks_periodic; | |||
| ticker->ticks_to_expire += | |||
| ticker_remainder_inc(ticker); | |||
There was a problem hiding this comment.
Correct, this is needed for Nordic!
mtpr-ot
approved these changes
Feb 20, 2020
aescolar
dismissed
thoh-ot’s stale review
MTPR has reviewed the ciker changes and is ok with them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition in radio abort requested by flash
driver. It is possible that during abort function execution,
PPI setup to start radio fires. Hence, check explicitly in
cleanup function for radio being in use and disable it.
Fixes #22945.
Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no