scripts: yet another runners fix #23171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes its true value clearer, and will make a later bug fix patch easier to understand. Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
This will also make the reason for a following bug fix easier to see. Update a comment block to include all the work that needs doing. Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
This is yet another bug introduced by the move to runners.yaml. Sigh. I should have tested this better. Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
mbolivar
added
bug
jhedberg
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit eb95bed fixed an issue preventing board.cmake files from using arguments like --hex-file in
board_runner_args().Unfortunately, it broke the ability to use those types of arguments from the command line. Fix that.
Only the last commit (
scripts: run_common: fix command line --hex-file and friends) is a fix. The other two are there to hopefully make this easier to review. Since it's so late in the development cycle, I'm fine with dropping them and just making the change in the last patch.