Fix SAM UART driver irq_update implementation #23279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `irq_update` UART API function must always return 1 according to the API documentations. This commit fixes the `irq_update` API function to unconditionally return '1'. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
The `irq_update` UART API function must always return 1 according to the API documentations. This commit fixes the `irq_update` API function to unconditionally return `1`. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
stephanosio
added
area: Drivers
area: UART
pabigot
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
I guess this has to be done given the documentation. IMO it would be better if uart_irq_update() returned -ENOTSUP if the feature was not available, and allowed any non-negative value to be returned for success so that useful information could be exposed to callers for diagnostic and platform-specific purposes.
If somebody's depending on this feature an API change to allow it may be appropriate.
mnkp
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
irq_updateUART API function implementation for the Atmel SAM family U(S)ART driver is not in compliance with the API documentation, which specifies that the function must always return1.This patch fixes the API implementation to unconditionally return
1.Fixes #23278.