[Backport-v2.2-branch] Bluetooth: controller: split: correct timing calculation in PKT_US #23570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in the PKT_US resulted in wrong calculations for the 2M phy. Fixes the bug, verified on EBQ. Also adds some defines for improved readability. Fixes zephyrproject-rtos#23482 Signed-off-by: Andries Kruithof <Andries.Kruithof@nordicsemi.no>
kruithofa
added
bug
thoh-ot
approved these changes
Mar 18, 2020
aescolar
changed the title
aescolar
approved these changes
Mar 18, 2020
kruithofa
added a commit
to kruithofa/zephyr
that referenced
this pull request
Mar 19, 2020
Fixes zephyrproject-rtos#23482. There is a bug in calculation of time for the DLE procedure: the preamble size is incorrect for the 2M phy This is for the legacy code, see PR zephyrproject-rtos#23570 for the split controller Signed-off-by: Andries Kruithof <Andries.Kruithof@nordicsemi.no>
wopu-ot
approved these changes
Mar 19, 2020
dagbja
approved these changes
Mar 19, 2020
|
@carlescufi Please advise on what more info is required |
|
@carlescufi, is this still waiting for approval? |
No, this is in the Ready column of the Backports project. This means that it can be merged at any time, but I will leave it to @jhedberg to decide when. |
Fair enough. The sooner the 2.2 backports are merged, the sooner we will start doing serious testing on the branch. |
jhedberg
approved these changes
Apr 12, 2020
pkral78
pushed a commit
to cloudfieldcz/zephyr
that referenced
this pull request
Aug 4, 2020
Fixes zephyrproject-rtos#23482. There is a bug in calculation of time for the DLE procedure: the preamble size is incorrect for the 2M phy This is for the legacy code, see PR zephyrproject-rtos#23570 for the split controller Signed-off-by: Andries Kruithof <Andries.Kruithof@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23482
A bug in the PKT_US resulted in wrong calculations for the 2M phy since the preamble size was incorrect. This results in reduced throughput since data that should fit in one packet was split in two packets.
Fixes the bug, verified on EBQ.
Also adds some defines for improved readability.
See also PR #23557 which is for the master branch
Signed-off-by: Andries Kruithof Andries.Kruithof@nordicsemi.no