cmake: Fix shield bug when BOARD_ROOT is a list #23609
Conversation
Fix bug where SHIELDS would be marked as "not found" in the NOT_FOUND_SHIELD_LIST when they were present, just not in the first BOARD root in the BOARD_ROOT list. Instead of marking shields in the NOT_FOUND_SHIELD_LIST, we (continue) popping shields from SHIELD and check if there are any shields left in SHIELD. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
SebastianBoe
added
area: Build System
area: Shields
| list(APPEND | ||
| shield_dts_fixups | ||
| ${shield_dir}/${s_dir}/dts_fixup.h | ||
| list(APPEND |
There was a problem hiding this comment.
Is that still possible to have shields fixup?
This is not the case anymore in main tree at least, I'm not sure in case of out-of tree shields
Maybe this could be totally removed (in a dedicated change).
There was a problem hiding this comment.
I have not been following the DT changes, so I'm not sure.
There was a problem hiding this comment.
Ok.
So, after a quick look, there is nothing that prevent it, but this mainly depends on drivers (sensors and components available on shields) implementations which should no use them.
Now, this is correctly done in in-tree drivers, but we don't know about potential out-of-tree support.
Anyway, support for fixup should be removed short term with on going changes in device tree support. Support removal in shields could be done at that time when supported is removed globally.
Fix bug where SHIELDS would be marked as "not found" in the
NOT_FOUND_SHIELD_LIST when they were present, just not in the first
BOARD root in the BOARD_ROOT list.
Instead of marking shields in the NOT_FOUND_SHIELD_LIST, we (continue)
popping shields from SHIELD and check if there are any shields left in
SHIELD.
Signed-off-by: Sebastian Bøe sebastian.boe@nordicsemi.no