Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: nxp_imx: Fix typo in linker script for i.MX RT #23902

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

arvid-r
Copy link
Collaborator

@arvid-r arvid-r commented Mar 29, 2020

Fix typo where DT_REG_ADDR was used istead of DT_REG_SIZE in linker script for i.MX RT socs and their ITCM and DTCM memories.

@arvid-r arvid-r requested a review from MaureenHelm as a code owner March 29, 2020 20:32
@zephyrbot
Copy link
Collaborator

zephyrbot commented Mar 29, 2020

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@arvid-r
Copy link
Collaborator Author

arvid-r commented Mar 29, 2020

Maybe @galak should take a look. My first PR ever, so I apologize if I messed up somehow.

@arvid-r arvid-r changed the title Fix typo in linker script for i.MX RT soc: Fix typo in linker script for i.MX RT Mar 29, 2020
@arvid-r arvid-r changed the title soc: Fix typo in linker script for i.MX RT soc: nxp_imx: Fix typo in linker script for i.MX RT Mar 29, 2020
@galak
Copy link
Collaborator

galak commented Mar 30, 2020

@arvid-r can you merge all these commits into just one. The change itself looks fine.

@arvid-r
Copy link
Collaborator Author

arvid-r commented Mar 30, 2020

Thanks. I'll try to figure out how.

Fix typo where DT_REG_ADDR was used istead of DT_REG_SIZE in
linker script for i.MX RT socs and their ITCM and DTCM memories.

Signed-off-by: Arvid Rosén <arvid@softube.com>
@arvid-r
Copy link
Collaborator Author

arvid-r commented Mar 30, 2020

Learning git still, but I think I managed to squash the commits now

@ioannisg ioannisg added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Mar 30, 2020
@galak
Copy link
Collaborator

galak commented Mar 30, 2020

@arvid-r thanks for the PR!

@galak galak merged commit 7626705 into zephyrproject-rtos:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants