Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: flash: nrf: Fix radio sync with BLE LL split controller #23905

Merged

Conversation

cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Mar 30, 2020

Delay radio abort called in the flash driver to emulate the
behavior of pre-empt timeout in Bluetooth LL split
controller. Without this, the driver aborted radio events
in its reserved time space.

Relates to #23815.

Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no

@cvinayak cvinayak added bug The issue is a bug, or the PR is fixing a bug area: Bluetooth area: Flashing labels Mar 30, 2020
@cvinayak cvinayak requested a review from nvlsianpu March 30, 2020 06:32
@pdunaj pdunaj requested review from MarekPieta and pdunaj March 30, 2020 07:28
@cvinayak cvinayak requested review from kruithofa and dagbja March 30, 2020 16:09
@nvlsianpu nvlsianpu requested a review from de-nordic April 1, 2020 11:17
@nvlsianpu
Copy link
Collaborator

@de-nordic Please review.

@de-nordic
Copy link
Collaborator

I have merged it, for test, with https://github.com/zephyrproject-rtos/zephyr/pull/23390/files and they seem to work fine together.

Delay radio abort called in the flash driver to emulate the
behavior of pre-empt timeout in Bluetooth LL split
controller. Without this, the driver aborted radio events
in its reserved time space.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak cvinayak force-pushed the github_flash_driver_fix branch from 831e53a to 14a2aa3 Compare April 2, 2020 07:02
@nvlsianpu
Copy link
Collaborator

@de-nordic looks fine now

@de-nordic de-nordic self-requested a review April 2, 2020 09:09
@de-nordic
Copy link
Collaborator

de-nordic commented Apr 2, 2020

I have done comparison tests of mcumgr upload of 150KB binary for this (rebased to zephyr master) and the vanilla zephyr master; this test is for writes only and it seems that this PR is faster in writes than the vanilla zephyr. The upload rates were as follows:

  • vanilla zephyr circa 5.80KiB/s
  • this PR circa 6.39KiB/s

I have used nrf52840_pca10056.

Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine.

@carlescufi carlescufi merged commit 0d8eb1c into zephyrproject-rtos:master Apr 3, 2020
@cvinayak cvinayak deleted the github_flash_driver_fix branch March 1, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants