-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: flash: nrf: Fix radio sync with BLE LL split controller #23905
drivers: flash: nrf: Fix radio sync with BLE LL split controller #23905
Conversation
@de-nordic Please review. |
I have merged it, for test, with https://github.com/zephyrproject-rtos/zephyr/pull/23390/files and they seem to work fine together. |
Delay radio abort called in the flash driver to emulate the behavior of pre-empt timeout in Bluetooth LL split controller. Without this, the driver aborted radio events in its reserved time space. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
831e53a
to
14a2aa3
Compare
@de-nordic looks fine now |
I have done comparison tests of mcumgr upload of 150KB binary for this (rebased to zephyr master) and the vanilla zephyr master; this test is for writes only and it seems that this PR is faster in writes than the vanilla zephyr. The upload rates were as follows:
I have used nrf52840_pca10056. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine.
Delay radio abort called in the flash driver to emulate the
behavior of pre-empt timeout in Bluetooth LL split
controller. Without this, the driver aborted radio events
in its reserved time space.
Relates to #23815.
Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no