[backport v2.2] lib: updatehub: Minor bug fixes #24066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix all build warnings. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> (cherry picked from commit 92f9cd9)
The MAX_PAYLOAD_SIZE must reflect the size of COAP_BLOCK_x. This is necessary becase BLOCK size represents max payload size. The current value create inconsistencies for coap lib. The same way, MAX_DOWNLOAD_DATA must allocate sufficient space for MAX_PAYLOAD_SIZE plus all space for coap header etc. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> (cherry picked from commit 5f5919a)
Extract finish sha256 calc method. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> (cherry picked from commit 1fe1b0e)
The current version aborts update when found last transfer block. Now, system checks only at end of coap block transfer total size and install if download is ok. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> (cherry picked from commit 1128eab)
After a success image download, UpdateHub needs inform MCUboot that must test new image and then, on success, commit this new image. This add missing upgrade request call step and fixes the upgarde flow. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> (cherry picked from commit d1e2d34)
nandojve
changed the title
jukkar
approved these changes
Apr 7, 2020
|
Please create at least one issue that you can reference from all the backport PRs |
We don't have a reported issue number. One of our customers reported those issues. Should we report it anyway? |
A malformed JSON payload that is received from an UpdateHub server may trigger memory corruption in the Zephyr OS. This could result in a denial of service in the best case, or code execution in the worst case. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
Use bin2hex instead inline conversion. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
Improve buffer overflow security on probe_cb. This ensures that socket buffer have fixed lenght and content received by COAP fills properly on metadata buffer. After that, ensures that metadata content is a valid string with length lower than metadata size. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
|
Added #24154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport the fixes made in #23885.
fixes #24211