samples: philosophers: evaluate variables coming from command line #24288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
changed the title
nashif
requested review from
finikorg,
andrewboie,
dcpleung,
ioannisg and
carlescufi
finikorg
reviewed
Apr 12, 2020
dcpleung
approved these changes
Apr 12, 2020
The variables passed by sanitycheck and west were being ignored because cmake knows nothing about them. Fixes zephyrproject-rtos#24178 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variables passed by sanitycheck and west were being ignored because
cmake knows nothing about them.
Fixes #24178