Fix system clock driver selection for cortex m #24348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisg
reviewed
Apr 14, 2020
ioannisg
reviewed
Apr 14, 2020
ioannisg
added
Trivial
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
b0661
force-pushed
the
pr_systick_reinstall
branch
from
bc645b2 to
1eea145
Compare
ioannisg
reviewed
Apr 14, 2020
The selection of the Cortex M systick driver to be used as a system clock driver is controlled by CONFIG_CORTEX_M_SYSTICK. To replace it by another driver CONFIG_CORTEX_M_SYSTICK must be set to 'n'. Unfortunately this also controls the interrupt vector for the systick interrupt. It is now routed to z_arm_exc_spurious. Remove the dependecy on CONFIG_CORTEX_M_SYSTICK and route to z_clock_isr as it was before zephyrproject-rtos#24012. Fixes zephyrproject-rtos#24347 Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
b0661
force-pushed
the
pr_systick_reinstall
branch
from
1eea145 to
a44efc6
Compare
Done |
ioannisg
approved these changes
Apr 15, 2020
stephanosio
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selection of the Cortex M systick driver to be used as a system clock driver
is controlled by CONFIG_CORTEX_M_SYSTICK.
To replace it by another driver CONFIG_CORTEX_M_SYSTICK must be set to 'n'.
Unfortunately this also controls the interrupt vector for the systick interrupt.
It is now routed to z_arm_exc_spurious.
Remove the dependecy on CONFIG_CORTEX_M_SYSTICK and route to z_clock_isr as it
was before #24012.
Fixes #24347
Signed-off-by: Bobby Noelte b0661n0e17e@gmail.com