soc: intel_s1000: fix SMP build error #24826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During devicetree macro changes, LPSRAM_BOOT_VECTOR_ADDR pointed to another macro which was renamed to a non-existent one. Fix it so that SMP builds again. Fixes zephyrproject-rtos#24720 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
andrewboie
approved these changes
Apr 29, 2020
|
huh, I wonder how this breakage got past CI |
|
i was wondering the same. |
andyross
approved these changes
Apr 29, 2020
galak
approved these changes
Apr 29, 2020
galak
added
the
Trivial
this fails only when build the smp test or when SMP is enabled, the change is in the SoC, so CI on PRs would not trigger building everythng for this board, thats why it was not caught here, but is caught in the nightly CI run. |
nashif
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During devicetree macro changes, LPSRAM_BOOT_VECTOR_ADDR
pointed to another macro which was renamed to a non-existent
one. Fix it so that SMP builds again.
Fixes #24720
Signed-off-by: Daniel Leung daniel.leung@intel.com