Bluetooth: controller: Added support for vendor ticker nodes #25066
Conversation
| int "Range of ticker id constants reserved for proprietary ticker nodes" | ||
| depends on BT_CTLR_USER_EXT | ||
| default 0 | ||
| range 0 10 |
There was a problem hiding this comment.
Do we need to add a range limitation on this?
There was a problem hiding this comment.
Do we need to add a range limitation on this?
No we don't need the range, but I prefer to have it to discourage from just using any number. Memory usage is quite high per node.
| #if defined(CONFIG_BT_CTLR_USER_EXT) | ||
| TICKER_ID_USER_BASE, | ||
| TICKER_ID_USER_LAST = (TICKER_ID_USER_BASE + | ||
| CONFIG_BT_CTLR_USER_TICKER_ID_RANGE - 1), | ||
| #endif /* CONFIG_BT_CTLR_USER_EXT */ | ||
|
|
There was a problem hiding this comment.
Doesn't this block only make sense if CONFIG_BT_CTLR_USER_TICKER_ID_RANGE > 0?
There was a problem hiding this comment.
Doesn't this block only make sense if CONFIG_BT_CTLR_USER_TICKER_ID_RANGE > 0?
Correct. Should we add the condition CONFIG_BT_CTLR_USER_TICKER_ID_RANGE > 0 to line 57?
There was a problem hiding this comment.
Doesn't this block only make sense if CONFIG_BT_CTLR_USER_TICKER_ID_RANGE > 0?
Correct. Should we add the condition CONFIG_BT_CTLR_USER_TICKER_ID_RANGE > 0 to line 57?
That would make sense.
|
Shippable failures are not from my commit, rebased... |
With BT_CTLR_USER_TICKER_ID_RANGE it is possible for vendors to add a number of ticker nodes for proprietary purposes. The feature depends on BT_CTLR_USER_EXT. Signed-off-by: Morten Priess <mtpr@oticon.com>
With BT_CTLR_USER_TICKER_ID_RANGE it is possible for vendors to add a
number of ticker nodes for proprietary purposes. The feature depends on
BT_CTLR_USER_EXT.
Signed-off-by: Morten Priess mtpr@oticon.com
Fixes #25067