drivers: usb_dc_sam: free endpoint memory on End of Reset event #25243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak logging for enable, disable, configure. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Free endpoint memory on End of Reset event (EORST). Fixes: zephyrproject-rtos#24626 Signed-off-by: Johann Fischer <j.fischer@phytec.de>
jfischer-no
added
bug
aurel32
approved these changes
May 12, 2020
There was a problem hiding this comment.
According to the datasheet, this should not be needed as the endpoint is supposed to be disabled and its memory de-allocated upon receiving a USB reset. However I confirm this is not what happens on the hardware and that your changes actually fix the issue. Thanks!
nandojve
approved these changes
May 13, 2020
| @@ -469,7 +469,7 @@ int usb_dc_ep_configure(const struct usb_dc_ep_cfg_data *const cfg) | |||
| return -EBUSY; | |||
| } | |||
|
|
|||
| LOG_DBG("ep %x, mps %d, type %d", cfg->ep_addr, cfg->ep_mps, | |||
| LOG_INF("Configure ep %x, mps %d, type %d", cfg->ep_addr, cfg->ep_mps, | |||
There was a problem hiding this comment.
On my view we can keep logs as LOG_DBG.
stephanosio
approved these changes
May 13, 2020
There was a problem hiding this comment.
Although the reason why EP 1-3 do not get disabled after reset, as stated in the datasheet, may require further investigation, this patch does fix the problem described in #24626.
[00:00:09.270,000] <inf> usb_cdc_acm: USB device configured
>>from EORST ISR<<
EP 0: enabled
EP 1: enabled
EP 2: enabled
EP 3: enabled
EP 4: disabled
EP 5: disabled
EP 6: disabled
EP 7: disabled
EP 8: disabled
EP 9: disabled
stephanosio
added
the
platform: Microchip SAM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Free endpoint memory on End of Reset event (EORST).
Fixes: #24626
I also tweaked logging a little to see what happens during configuration, but I can remove commit f689a5a if not desired.