-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver/counter/counter_ll_stm32_rtc.c: Add 1 tick to alarm #25367
driver/counter/counter_ll_stm32_rtc.c: Add 1 tick to alarm #25367
Conversation
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
be11966
to
e4dfe49
Compare
e4dfe49
to
6c4b5ce
Compare
6c4b5ce
to
ef4e381
Compare
…rproject-rtos#25367 Due to counter driver implementation change introduced with PR zephyrproject-rtos#25367 "driver/counter/counter_ll_stm32_rtc.c: Add 1 tick to alarm" It is necessary to adapt sample test (sanitycheck) to take into consideration 1 tick precision/tolerance. Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Add +1 tick to alarm in order to compensate the partially started tick. Alarm will expire between requested ticks and ticks+1. In case only 1 tick is requested, it will avoid that +1 Tick event occurs before alarm setting is finished. Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
ef4e381
to
5732b3a
Compare
I am not sure to catch your point: there is no PR number is the commit message of this RP. |
Due to counter driver implementation change "driver/counter/counter_ll_stm32_rtc.c: Add 1 tick to alarm" It is necessary to adapt sample test (sanitycheck) to take into consideration 1 tick precision/tolerance. Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is right: a small offset of 1 or 2 ticks depending on hardware is generally added to ensure late-to-set alarms don't occur.
Add +1 tick to alarm in order to compensate the partially started tick.
Alarm will expire between requested ticks and ticks+1.
In case only 1 tick is requested, it will avoid that +1 Tick event occurs
before alarm setting is finished.
Fixes #25366