Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: Make GPIO pin config default for LEDs instead of PWM #25456

Merged
merged 1 commit into from
May 20, 2020

Conversation

galak
Copy link
Collaborator

@galak galak commented May 19, 2020

Add an additional check for CONFIG_PWM to decide if pins associated with
LED are configured for GPIO or PWM.

Fixes #25337

Signed-off-by: Kumar Gala kumar.gala@linaro.org

@galak galak requested a review from MaureenHelm as a code owner May 19, 2020 17:26
@galak galak requested a review from henrikbrixandersen May 19, 2020 17:26
@galak galak added area: Boards bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug labels May 19, 2020
@galak galak added this to the v2.3.0 milestone May 19, 2020
@galak galak requested a review from carlescufi May 19, 2020 17:26
@zephyrbot
Copy link
Collaborator

zephyrbot commented May 19, 2020

All checks passed.

checkpatch (informational only, not a failure)

-:10: WARNING:LONG_LINE: line over 80 characters
#10: FILE: boards/arm/frdm_k82f/pinmux.c:36:
+#if DT_NODE_HAS_COMPAT_STATUS(DT_NODELABEL(ftm3), nxp_kinetis_ftm_pwm, okay) && CONFIG_PWM

-:23: WARNING:LONG_LINE: line over 80 characters
#23: FILE: boards/arm/hexiwear_k64/pinmux.c:33:
+#if DT_NODE_HAS_COMPAT_STATUS(DT_NODELABEL(ftm3), nxp_kinetis_ftm_pwm, okay) && CONFIG_PWM

-:36: WARNING:LONG_LINE: line over 80 characters
#36: FILE: boards/arm/twr_ke18f/pinmux.c:37:
+#if DT_NODE_HAS_COMPAT_STATUS(DT_NODELABEL(ftm0), nxp_kinetis_ftm_pwm, okay) && CONFIG_PWM

-:45: WARNING:LONG_LINE: line over 80 characters
#45: FILE: boards/arm/twr_ke18f/pinmux.c:49:
+#if DT_NODE_HAS_COMPAT_STATUS(DT_NODELABEL(ftm3), nxp_kinetis_ftm_pwm, okay) && CONFIG_PWM

- total: 0 errors, 4 warnings, 40 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@galak galak force-pushed the dt-pinmux-pwm-fix branch from e0ad1e7 to 313e9f1 Compare May 19, 2020 18:43
@galak galak requested a review from MaureenHelm May 19, 2020 18:43
Add an additional check for CONFIG_PWM to decide if pins associated with
LED are configured for GPIO or PWM.

Fixes zephyrproject-rtos#25337

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak force-pushed the dt-pinmux-pwm-fix branch from 313e9f1 to c31e24b Compare May 19, 2020 21:30
@galak galak requested a review from henrikbrixandersen May 19, 2020 21:30
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@carlescufi carlescufi merged commit 3393600 into zephyrproject-rtos:master May 20, 2020
@galak galak deleted the dt-pinmux-pwm-fix branch May 20, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Boards bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LED pins always configured as PWM outputs
5 participants