-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: sockets: socketpair: sample application and docs #25528
samples: sockets: socketpair: sample application and docs #25528
Conversation
All checks are passing now. checkpatch (informational only, not a failure)
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
Hehe... so looks like I'm implementing nanosleep(2). Probably better to do that in a separate PR ;-) Looks like newlib doesn't have its own implementation and just makes a syscall. Doesn't look like Zephyr has such a syscall atm. I was thinking of kludging it together with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
From #25528 (comment) And I didn't saw this and following lines. Because they were edited into an already posted comment, and the original content of that comment is what I got in email and considered it read. I mentioned this issue lately elsewhere. Please avoid editing comments for adding new information, post it as a new comment instead. It's ok to post a bunch of comments in row (if it's needed). (And I for one edit my comments, but only to fix typos/ambiguous wording). |
It looks like there was a copy-paste error made several years ago that is breaking this PR.
|
@cfriedt: I don't see a copy-paste error there. It's quite a natural way to use the same name for both |
@pfalcon - it's inconsistence. Elsewhere in the file there is e.g.
The actual error here is specific to nrf52bsim I think. I didn't see the entirety of the error message... but posix types are defined twice.
|
Support for the socketpair(2) system call was recently added for 2.3.0 . This change adds a sample application that demonstrates how it can be used. Fixes #25527 Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
nrf52bsim is another instance of CONFIG_ARCH_POSIX, aka native_posix issue-alike. Anyway, feel free to propose a fix. As usual, submitting it as a separate PR raises chances for it to be processed sooner rather than later (but I assume, @carlescufi is busy with high-priority fixes by now). |
@carlescufi - sample application and docs would be good to accompany socketpair for 2.3.0. I'm sure it's too late now, but just thought I would throw it out there. |
Given that socketpair() is just introduced for 2.3, we hardly can make it worse for anyone with further changes, only better. @carlescufi, adding 2.3 milestone to help you not forget about this case ;-). |
I am merging this because it's a sample that demonstrates a new feature that was introduced in 2.3.0. |
Support for the socketpair(2) system call was recently added for 2.3.0.
This change adds a sample application that demonstrates how it can be used.
Fixes #25527