Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: ieee802154: Allow to disable auto-start of 802.15.4 interfaces #25629

Conversation

markus-becker-tridonic-com
Copy link
Contributor

Some radio drivers need configuration before start-up. Up to now only
the RF2XX drivers allowed this, but other radio drivers need this as
well. In particular for setting EUI64 addresses.

Signed-off-by: Markus Becker markus.becker@tridonic.com

Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor nits.

subsys/net/l2/Kconfig Outdated Show resolved Hide resolved
subsys/net/l2/Kconfig Outdated Show resolved Hide resolved
subsys/net/l2/ieee802154/ieee802154.c Outdated Show resolved Hide resolved
subsys/net/l2/openthread/openthread.c Outdated Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortened the LOG_DBG message to stay below < 80 chars.

subsys/net/l2/Kconfig Outdated Show resolved Hide resolved
subsys/net/l2/Kconfig Outdated Show resolved Hide resolved
subsys/net/l2/ieee802154/ieee802154.c Outdated Show resolved Hide resolved
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

subsys/net/l2/Kconfig Outdated Show resolved Hide resolved
@zephyrbot
Copy link
Collaborator

zephyrbot commented May 28, 2020

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Copy link
Collaborator

@tbursztyka tbursztyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a tiny stuff. good to go afterwards

drivers/ieee802154/Kconfig Outdated Show resolved Hide resolved
@markus-becker-tridonic-com markus-becker-tridonic-com force-pushed the ieee802154-no-auto-start branch 2 times, most recently from e78987f to e63ccd0 Compare May 28, 2020 11:44
@nandojve nandojve added this to the v2.3.0 milestone May 28, 2020
@carlescufi carlescufi removed this from the v2.3.0 milestone May 29, 2020
@carlescufi
Copy link
Member

This is really a new feature so it will have to wait until we release 2.3.0

@markus-becker-tridonic-com
Copy link
Contributor Author

@carlescufi 2.3 is released now, can it be merged now?

Some radio drivers need configuration before start-up. Up to now only
the RF2XX drivers allowed this, but other radio drivers need this as
well. In particular for setting EUI64 addresses.

Signed-off-by: Markus Becker <markus.becker@tridonic.com>
@markus-becker-tridonic-com
Copy link
Contributor Author

rebased on master post 2.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants