drivers: led: add shell support #25946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces the "led" shell command. This allows to run the LED API functions (and to test the LED drivers) from the Zephyr shell. The subcommands "on", "off" and "set_brightness" are supported. Signed-off-by: Simon Guinot <simon.guinot@seagate.com>
henrikbrixandersen
added
area: LED
jakub-uC
reviewed
Jul 30, 2020
Contributor
jakub-uC
left a comment
jakub-uC
left a comment
There was a problem hiding this comment.
Please update the types. Apart from that LGTM
| shell_print(shell, "%s: setting LED %d brightness to %d", | ||
| dev->name, led, brightness); | ||
|
|
||
| err = led_set_brightness(dev, led, (u8_t) brightness); |
Contributor
Author
| static int cmd_on(const struct shell *shell, size_t argc, char **argv) | ||
| { | ||
| struct device *dev; | ||
| u32_t led; |
Contributor
There was a problem hiding this comment.
Please use uint32_t type.
| static int cmd_off(const struct shell *shell, size_t argc, char **argv) | ||
| { | ||
| struct device *dev; | ||
| u32_t led; |
Contributor
There was a problem hiding this comment.
Please use uint32_t type.
| }; | ||
|
|
||
| static int parse_common_args(const struct shell *shell, char **argv, | ||
| struct device **dev, u32_t *led) |
Contributor
There was a problem hiding this comment.
Please use uint32_t type.
Contributor
Author
|
Already merged as part of PR #26101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the "led" shell command. This allows to run the
LED API functions (and to test the LED drivers) from the Zephyr shell.
The subcommands "on", "off" and "set_brightness" are supported.
Signed-off-by: Simon Guinot simon.guinot@seagate.com