include/drivers/flash: correction on the unrestricted alignment of writes #28192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvlsianpu
requested review from
carlescufi,
galak,
MaureenHelm and
nashif
as code owners
nvlsianpu
requested review from
pabigot and
carlescufi
and removed request for
carlescufi
nvlsianpu
added
area: API
pabigot
reviewed
Sep 8, 2020
| @@ -133,8 +133,7 @@ static inline int z_impl_flash_read(const struct device *dev, off_t offset, | |||
| * @brief Write buffer into flash memory. | |||
| * | |||
| * All flash drivers support a source buffer located either in RAM or | |||
| * SoC flash, without alignment restrictions on the source address, or | |||
| * write size or offset. | |||
| * SoC flash, without alignment restrictions on the source address. | |||
There was a problem hiding this comment.
Could you expand on this, e.g.
Write size and offset must be multiples of flash_get_write_block_size(dev).
(if that's true)
…ites Telling that all the driver supports unaligned writes was and is not true. Drivers only have to support any source buffer. This fix message introduced by zephyrproject-rtos#23628 Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu
force-pushed
the
fix-flash-write-api-dsc
branch
from
2aca1bb to
c9c688e
Compare
pabigot
approved these changes
Sep 8, 2020
carlescufi
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telling that all the driver supports unaligned writes was and
is not true. Drivers only have to support any source buffer.
This fixes message introduced by #23628
fixes #28193
Signed-off-by: Andrzej Puzdrowski andrzej.puzdrowski@nordicsemi.no