nordic_nrf: Kconfig.peripherals: Get Kconfig setting from DT #35398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
dt-kconfig
branch
2 times, most recently
from
9329d26 to
23a5ecd
Compare
oyvindronningstad
force-pushed
the
dt-kconfig
branch
2 times, most recently
from
fe5f1c2 to
cffc873
Compare
There was a problem hiding this comment.
My quick feedback is:
dt_compat_enabled()is not quite right; we instead should adddt_has_compat()to kconfigfunctions.py which tests if the compatible exists at all, not requiring it to be enabled- that would allow removing the
status = "okay";in the gpiote node for arduino_nano_33_ble
could just usedef_bool $(dt_has_compat,$(DT_COMPAT_FOO)) - the missing nodes should probably be added with trivial bindings that just have a reg, except the RADIO case, which has a binding and just needs node definitions
oyvindronningstad
force-pushed
the
dt-kconfig
branch
from
cffc873 to
ca02a12
Compare
True when the compat exists in the tree regardless of status. Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
- For trivial cases where the name is directly translatable to the compat in DTS. - For multi-instance peripherals. Remove 'select' statements when the info is retrieved from DT. Anomalies: - NRF_POWER is missing from DTS for nRF52 and nRF51 SoCs. - A handful of peripherals are missing from DTS altogether, e.g. ACL/BPROT/MPU, PPI, CCM/ECB, RADIO. - The existing HAS_HW_NRF_TWI, SPI, etc that share a peripheral ID don't respect the compat assignment, so this this patch does not either, even though it now could. - EGU is not present in DTS for nRF51 and nRF52 SOCs. - SWI is not present (duplicate/renaming of EGU?). Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
Indicating the presence of the KMU peripheral. Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
oyvindronningstad
force-pushed
the
dt-kconfig
branch
from
ca02a12 to
59a324d
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'select' statements when the info is retrieved from DT.
Signed-off-by: Øyvind Rønningstad oyvind.ronningstad@nordicsemi.no