Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: final release notes for v3.1.0 #46271

Conversation

mbolivar-nordic
Copy link
Contributor

This pull request finalizes the release notes page.

There are still a few more documentation related tasks left to do before the release. These will be deferred to a subsequent PR.

@mbolivar-nordic mbolivar-nordic requested a review from nashif as a code owner June 3, 2022 20:29
@github-actions github-actions bot added area: Documentation Release Notes To be mentioned in the release notes labels Jun 3, 2022
@mbolivar-nordic mbolivar-nordic force-pushed the doc-3.1-final-release-notes branch from d9b9da7 to 382268d Compare June 3, 2022 20:31
@mbolivar-nordic mbolivar-nordic added this to the v3.1.0 milestone Jun 3, 2022
@mbolivar-nordic
Copy link
Contributor Author

We could use someone with superpowers to override the compliance failures. Those are copied straight from the github issue titles themselves.

@mbolivar-nordic mbolivar-nordic requested a review from cfriedt June 3, 2022 20:38
@mbolivar-nordic mbolivar-nordic force-pushed the doc-3.1-final-release-notes branch from 382268d to 045ab82 Compare June 3, 2022 20:39
MaureenHelm
MaureenHelm previously approved these changes Jun 3, 2022
@mbolivar-nordic mbolivar-nordic requested a review from dkalowsk June 3, 2022 20:44
Follow along with the release checklist (zephyrproject-rtos#43286) like this:

$ ./scripts/release/list_issues.py -o zephyrproject-rtos -r zephyr -s
2022-02-22 -f issues.txt

Then copy issues.txt into the right place in the doc, and clean up the
resulting .rst errors by properly escaping and converting the markdown
format used in github issue titles.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
This prints the contents of a zephyr-bugs-$DATE.pickle file in a
format similar to the output of list_issues.py.

It will be useful to have this in tree so that we can better record
the known issues at the time of a particular zephyr release.

The pickle file itself should be created using the bug snapshot
workflow defined in .github/workflows/bug_snapshot.yaml, which can be
triggered manually from this URL:

https://github.com/zephyrproject-rtos/zephyr/actions/workflows/bug_snapshot.yaml

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Every release notes page includes a section for known issues.

In previous releases, we have linked to a GitHub query which displays
open issues. The problem with this approach is that the information
immediately goes stale, making this section's content less than useful.

We can do better now that we have a bug snapshot workflow and a script
capable of dumping snapshot contents in the same almost-rst-format
used by list_issues.py.

Use it as follows to archive the known open bugs at time of release:

$ wget https://builds.zephyrproject.io/zephyr/bug-snapshot/zephyr-bugs-2022-06-03.pickle.xz
$ unxz zephyr-bugs-2022-06-03.pickle.xz
$ ./scripts/dump_bugs_pickle.py zephyr-bugs-2022-06-03.pickle

Then copy paste the output into the release notes and handle .rst
escapes in the same way has previously been done for closed issues
since the last release.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
dkalowsk
dkalowsk previously approved these changes Jun 3, 2022
Copy link
Contributor

@dkalowsk dkalowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as approved as you may be okay with these bits in there. I don't believe they add any value to the release notes, but I'll leave that to you to make the call. Everything else looks good to the PR.

doc/releases/release-notes-3.1.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.1.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.1.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.1.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.1.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.1.rst Show resolved Hide resolved
@mbolivar-nordic
Copy link
Contributor Author

mbolivar-nordic commented Jun 3, 2022

@dkalowsk feedback addressed, thank you.

dkalowsk
dkalowsk previously approved these changes Jun 3, 2022
Make a pass through the file, trying to fix as many issues as possible
with how the notes are written. This includes fixes for tense and
invalid .rst role usage, as well as removal of any sections which have
missing content.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
This needs to be in the "API changes" section, instead of in a
"Bluetooth" section where it currently is.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
For some reason, there are two different sections covering bluetooth.
This is clearly incorrect; fix it by moving the content into a single
section.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
There are three lists of issues in the release notes:

- security vulnerabilities which received CVEs
- other open bugs
- resolved issues

(Here, "issue" is a strictly more general term than "bug": every bug
is an issue, not every issue is a bug. This is GitHub-specific
jargon.)

The current structure is awkward. Clean it up by unifying the
lists under a single top level section and cleaning up the distinction
between issues and bugs.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Apply suggestions from Dan Kalowsky to clean up extraneous issues
included in the script's output.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Remove that from the title.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
@mbolivar-nordic
Copy link
Contributor Author

Fixed a doc build error; not sure why I didn't notice that in my local builds.

@mbolivar-nordic mbolivar-nordic mentioned this pull request Jun 3, 2022
52 tasks
@mbolivar-nordic mbolivar-nordic mentioned this pull request Jun 3, 2022
@MaureenHelm MaureenHelm merged commit e27565e into zephyrproject-rtos:main Jun 4, 2022
@carlescufi carlescufi mentioned this pull request Jun 5, 2022
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Documentation Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants