[RFC] Cache API rework #50988
Merged
[RFC] Cache API rework #50988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocaione
force-pushed
the
cache_rework
branch
3 times, most recently
from
ff39b71 to
30a9b78
Compare
zephyrbot
added
manifest
west
manifest-libmetal
DNM
carlocaione
force-pushed
the
cache_rework
branch
from
30a9b78 to
b8f7001
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
carlocaione
force-pushed
the
cache_rework
branch
5 times, most recently
from
749b841 to
9faa76b
Compare
carlocaione
requested review from
dcpleung,
andyross,
nashif,
carlescufi,
galak,
MaureenHelm,
npitre,
alexanderwachter,
henrikbrixandersen,
jhedberg and
aasthagr
as code owners
carlocaione
force-pushed
the
cache_rework
branch
from
6adefaa to
3be93d6
Compare
carlocaione
force-pushed
the
cache_rework
branch
4 times, most recently
from
9f9c826 to
2c1226f
Compare
|
Why DNM? |
At least zephyrproject-rtos/libmetal#17 needs to go in first. |
The cache operations must be quick, optimized and possibly inlined. The current API is clunky, functions are not inlined and passing parameters around that are basically always known at compile time. In this patch we rework the cache functions to allow us to get rid of useless parameters and make inlining easier. In particular this changeset is doing three things: 1. `CONFIG_HAS_ARCH_CACHE` is now `CONFIG_ARCH_CACHE` and `CONFIG_HAS_EXTERNAL_CACHE` is now `CONFIG_EXTERNAL_CACHE` 2. The cache API has been reworked. 3. Comments are added. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
This is useful to prove that the implementation of the API is done correctly. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
And use the new API. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
And use the new API. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
And use the new API. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
To be compliant to the new cache API. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Fix the usage to be compliant to the new cache API. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Make libmetal using the new zephyr cache APIs. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Bump the openamp version to v2022.10.0 Signed-off-by: Carlo Caione <ccaione@baylibre.com>
carlocaione
force-pushed
the
cache_rework
branch
from
2c1226f to
b0c4537
Compare
nashif
approved these changes
Dec 1, 2022
teburd
approved these changes
Dec 1, 2022
microbuilder
approved these changes
Dec 1, 2022
|
Just curious: Why was the openamp version updated as part of this PR (from 1258d35)? |
It was requested by the OpenAMP maintainer. See #50988 (review) |
ycsin
reviewed
May 8, 2024
| @@ -804,7 +804,7 @@ static void enable_mmu_el1(struct arm_mmu_ptables *ptables, unsigned int flags) | |||
| isb(); | |||
|
|
|||
| /* Invalidate all data caches before enable them */ | |||
| sys_cache_data_all(K_CACHE_INVD); | |||
There was a problem hiding this comment.
Just want to note that we are affected by this change while working on internal firmware upgrade from v2.x, hopefully we are the only out-of-tree user..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the outcome of the discussion in #50747 and #50136.
The cache API is now composed by:
cache_{data,instr}_enable()cache_{data,instr}_disable()cache_{data,instr}_line_size_get()cache_{data,instr}_flush_all()cache_{data,instr}_flush_range(addr, size)cache_{data,instr}_invd_all()cache_{data,instr}_invd_range(addr, size)cache_{data,instr}_flush_and_invd_all(addr, size)cache_{data,instr}_flush_and_invd_range(addr, size)And functions can now be inlined (see ARM64 implementation).
This is still an RFC.
IMPORTANT
Before this PR is considered to me merge-able we need to address two issues: