soc: intel_adsp: cavs: start using zephyr power management #55667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juimonen
force-pushed
the
pm_move
branch
4 times, most recently
from
6e051f7 to
6540a7d
Compare
zephyrbot
added
area: Xtensa
zephyrbot
requested review from
aborisovich,
ceolin,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
marc-hb,
marcinszkudlinski,
MaureenHelm,
softwarecki and
tmleman
|
related sof side changes thesofproject/sof#7183 |
tmleman
reviewed
Mar 17, 2023
kv2019i
reviewed
Mar 20, 2023
There was a problem hiding this comment.
In general looks good. Might be useful to add a note to commit that this is based on code that already exists (and has been tested) in SOF mainline.
I'm a bit unsure about the D0i3 state. I don't think this patch has all functionality to enable real D0i3 on this hardware and I think that is ok. Enabling D3 via Zephyr native code, and having clock gating in idle state is ok initial step. But if we don't do the full D0i3 flow, then there are bits of code that are a bit misleading in this version (some preps that would be needed to go to deeper idle sleep state, but not the full thing).
tmleman
reviewed
Mar 21, 2023
tmleman
previously approved these changes
Mar 21, 2023
softwarecki
previously approved these changes
Mar 21, 2023
Start using zephyr power management in cavs platform in a similar way that is already done in ace. This commit only addresses the power off/on sequence. Runtime power management is not implemented. Signed-off-by: Jaska Uimonen <jaska.uimonen@linux.intel.com>
kv2019i
previously approved these changes
Mar 23, 2023
softwarecki
approved these changes
Mar 23, 2023
kv2019i
approved these changes
Mar 23, 2023
tmleman
approved these changes
Mar 23, 2023
nashif
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start using zephyr power management in cavs platform in a similar way than is already done in ace.